Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: trying to fix LOAD_EXAMPLES in ephemeral envs #29987

Closed
wants to merge 15 commits into from
Closed

fix: trying to fix LOAD_EXAMPLES in ephemeral envs #29987

wants to merge 15 commits into from

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Aug 21, 2024 •
edited
Loading

title ^^^

Using workflow_dispatch to trigger using gh workflow run ephemeral-env.yml --ref eph_env_fix

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Aug 21, 2024
@mistercrunch
Copy link
Member Author

/testenv up

@mistercrunch
Copy link
Member Author

first try logs: https://github.com/apache/superset/actions/runs/10493768010/job/29068509569

@mistercrunch
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Ephemeral environment spinning up at http://54.244.15.225:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@mistercrunch
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Ephemeral environment spinning up at http://35.165.145.1:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@michael-s-molina michael-s-molina added review:draft review:checkpoint Last PR reviewed during the daily review standup labels Aug 21, 2024
@mistercrunch
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Ephemeral environment spinning up at http://34.220.41.167:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas
Copy link
Member

Is this one of those cases where we have to merge it to see if it works?

@mistercrunch
Copy link
Member Author

Yeah it's confusing, I think it runs the main branch's corresponding action, not the one from this PR/branch

@pull-request-size pull-request-size bot added size/M and removed size/S labels Aug 21, 2024
@michael-s-molina
Copy link
Member

michael-s-molina commented Aug 22, 2024 •
edited
Loading

@mistercrunch Please check #29993 as it fixed the load examples problem in ephemeral envs.

@michael-s-molina michael-s-molina removed the review:checkpoint Last PR reviewed during the daily review standup label Aug 22, 2024
@mistercrunch
Copy link
Member Author

Please check #29993 as it fixed the load examples problem in ephemeral envs.

done-im-done

@mistercrunch
Copy link
Member Author

Closing for now, might re-start from here if issues with eph-envs show up again. Really hard to work on this stuff in the GHA / missing-secrets-locally context. Though next time I might try a supersetbot approach

@github-actions GitHub Actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro Awaiting requested review from villebro villebro will be requested when the pull request is marked ready for review villebro is a code owner

@geido geido Awaiting requested review from geido geido will be requested when the pull request is marked ready for review geido is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho will be requested when the pull request is marked ready for review eschutho is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas will be requested when the pull request is marked ready for review rusackas is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida will be requested when the pull request is marked ready for review betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai will be requested when the pull request is marked ready for review nytai is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda will be requested when the pull request is marked ready for review craig-rueda is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley john-bodley will be requested when the pull request is marked ready for review john-bodley is a code owner

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje will be requested when the pull request is marked ready for review kgabryje is a code owner

@dpgaspar dpgaspar Awaiting requested review from dpgaspar dpgaspar will be requested when the pull request is marked ready for review dpgaspar is a code owner

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code preset-io review:draft size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mistercrunch @rusackas @michael-s-molina