Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Duplicated example dataset #29993

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Aug 22, 2024

SUMMARY

#28789 duplicated the wb_health_population dataset which made our command that load the example data to fail. This PR simply removes the only chart that referenced the duplicated dataset and also removes the YAML file that was the root cause for the duplication.

TESTING INSTRUCTIONS

Check the you're able to load the examples correctly.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added data:dataset Related to dataset configurations doc:examples Related to example datasets and dashboards labels Aug 22, 2024
@michael-s-molina michael-s-molina added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.64%. Comparing base (76d897e) to head (7aa5cfd).
Report is 966 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29993       +/-   ##
===========================================
+ Coverage   60.48%   83.64%   +23.15%     
===========================================
  Files        1931      528     -1403     
  Lines       76236    38148    -38088     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31909    -14205     
+ Misses      28017     6239    -21778     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.95% <ø> (-0.22%) ⬇️
javascript ?
mysql 76.66% <ø> (?)
postgres 76.74% <ø> (?)
presto 53.50% <ø> (-0.30%) ⬇️
python 83.64% <ø> (+20.15%) ⬆️
sqlite 76.22% <ø> (?)
unit 60.31% <ø> (+2.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-s-molina
Copy link
Member Author

/testenv up

Copy link
Contributor

@michael-s-molina Ephemeral environment spinning up at http://54.244.13.91:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@michael-s-molina
Copy link
Member Author

michael-s-molina commented Aug 22, 2024

@sadpandajoe @mistercrunch @eschutho @rusackas I confirmed that this PR also fixed the ephemeral environment problem.

@michael-s-molina michael-s-molina merged commit eb2d69a into apache:master Aug 22, 2024
44 of 46 checks passed
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@sadpandajoe sadpandajoe added the cherry:checkpoint Last commit that was cherried into a release branch label Aug 22, 2024
sadpandajoe pushed a commit that referenced this pull request Aug 22, 2024
@sadpandajoe sadpandajoe linked an issue Aug 22, 2024 that may be closed by this pull request
3 tasks
@sadpandajoe sadpandajoe removed the cherry:checkpoint Last commit that was cherried into a release branch label Aug 23, 2024
@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels data:dataset Related to dataset configurations doc:examples Related to example datasets and dashboards size/XXL v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ephemeral instances no longer have any example data
2 participants