docs: find broken links using github-action-markdown-link-check #28437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
requested review from
villebro,
geido,
eschutho,
betodealmeida,
nytai,
mistercrunch,
craig-rueda,
john-bodley,
kgabryje and
dpgaspar
as code owners
github-actions
bot
added
github_actions
9 tasks
|
Wow, this takes FOREVER. |
| @@ -45,7 +45,7 @@ These features are **finished** but currently being tested. They are usable, but | |||
| - CACHE_IMPERSONATION | |||
| - CONFIRM_DASHBOARD_DIFF | |||
| - DRILL_TO_DETAIL | |||
| - DYNAMIC_PLUGINS: [(docs)](https://superset.apache.org/docs/configuration/running-on-kubernetes) | |||
There was a problem hiding this comment.
should we add an entry in htaccess? There's one that says RewriteRule ^docs/installation/running-on-kubernetes/$ /docs/installation/kubernetes [R=301,L] , but could use one for the exact link above too.
There was a problem hiding this comment.
Yeah, that makes sense. There are also a whole bunch more bad links that got turned up on this PR... I guess I'll slog through and do the same for those when time allows.
|
closing in favor of #28424 which is much faster, and more sensible to config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Following up on #28424, using another (relatively deprecated) action, while we figure out if ASF will let us use the first one.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION