-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Check markdown files for bad links using linkinator #28424
Conversation
@mistercrunch seems like the action isn't running :/ I'll investigate in the morning unless you see anything plainly obvious. |
visible here -> https://github.com/apache/superset/actions/runs/9027384874 |
I'll open another one with that other action. This one looked simpler when I opened it, but... I guess it's not so simple! I opened an Infra ticket to see if there's a preferred practice for cases like this: |
Actually, that other Action is also on a 3rd party repo, so that won't be any easier. |
Actually the truncation in the screenshot above cuts right before fully pointing to https://github.com/gaurav-nelson/github-action-markdown-link-check |
Ok, opened a PR using the other action here: #28437 This other action, however, is in maintenance mode, pending some replacement with the author. It also doesn't support multiple file extensions in its config, so we have to run it twice. That's a bit silly, but hopefully it'll work. |
Linkinator has now been added to the ASF allow list... let's see if this is simpler/faster than the other PR :) |
Sorry for all the noise. A rebase went quite goofy... I'll start chipping away at more of the failing links. |
(cherry picked from commit c3702be)
SUMMARY
Adding a little CI magic to test markdown files for problem links using Linkinator. Hopefully this remedies some of the issues stemming from moving pages around.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION