Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Check markdown files for bad links using linkinator #28424

Merged
merged 30 commits into from
Jul 29, 2024

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented May 10, 2024

SUMMARY

Adding a little CI magic to test markdown files for problem links using Linkinator. Hopefully this remedies some of the issues stemming from moving pages around.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added github_actions Pull requests that update GitHub Actions code preset-io doc Namespace | Anything related to documentation labels May 10, 2024
@rusackas
Copy link
Member Author

@mistercrunch seems like the action isn't running :/

I'll investigate in the morning unless you see anything plainly obvious.

@mistercrunch
Copy link
Member

Screenshot 2024-05-09 at 10 10 47 PM

visible here -> https://github.com/apache/superset/actions/runs/9027384874

@mistercrunch
Copy link
Member

@rusackas
Copy link
Member Author

I'll open another one with that other action. This one looked simpler when I opened it, but... I guess it's not so simple!

I opened an Infra ticket to see if there's a preferred practice for cases like this:
https://issues.apache.org/jira/issues/?filter=-2

@rusackas
Copy link
Member Author

Actually, that other Action is also on a 3rd party repo, so that won't be any easier.

@mistercrunch
Copy link
Member

It'd be good to know where the full complex rule lives behind this truncated one ->
Screenshot 2024-05-10 at 12 43 14 PM

@mistercrunch
Copy link
Member

Actually the truncation in the screenshot above cuts right before fully pointing to https://github.com/gaurav-nelson/github-action-markdown-link-check

@rusackas
Copy link
Member Author

Ok, opened a PR using the other action here: #28437

This other action, however, is in maintenance mode, pending some replacement with the author. It also doesn't support multiple file extensions in its config, so we have to run it twice. That's a bit silly, but hopefully it'll work.

@rusackas
Copy link
Member Author

Linkinator has now been added to the ASF allow list... let's see if this is simpler/faster than the other PR :)

@rusackas
Copy link
Member Author

Sorry for all the noise. A rebase went quite goofy...

I'll start chipping away at more of the failing links.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 29, 2024
@rusackas rusackas merged commit c3702be into master Jul 29, 2024
35 checks passed
@rusackas rusackas deleted the dead-link-check branch July 29, 2024 22:19
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Nov 13, 2024
sadpandajoe pushed a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Namespace | Anything related to documentation github_actions Pull requests that update GitHub Actions code preset-io size/M v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants