Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): bump node version in nvmrc files #27974

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix(node): bump node version in nvmrc files #27974

merged 1 commit into from
Apr 10, 2024

Conversation

rusackas
Copy link
Member

SUMMARY

@geido noticed I missed the .nvmrc files in this PR. This corrects that!

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

I did npm install on all three pieces of software and started them all as well. Looks good at first glance.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label Apr 10, 2024
@rusackas rusackas merged commit 601d011 into master Apr 10, 2024
31 of 32 checks passed
@rusackas rusackas deleted the nvmrc-bumps branch April 10, 2024 17:41
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 15, 2024
@rusackas @EnxDev
fix(node): bump node version in nvmrc files (apache#27974)
a590e02
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@rusackas @qleroy
fix(node): bump node version in nvmrc files (apache#27974)
6eaf171
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@rusackas @jzhao62
fix(node): bump node version in nvmrc files (apache#27974)
21781d7
@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label May 23, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@rusackas
fix(node): bump node version in nvmrc files (apache#27974)
c3f9fc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@geido geido Awaiting requested review from geido

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rusackas @michael-s-molina @john-bodley