Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(node): bumping Superset to Node 18 #27198

Merged
merged 4 commits into from
Apr 2, 2024
Merged

chore(node): bumping Superset to Node 18 #27198

merged 4 commits into from
Apr 2, 2024

Conversation

rusackas
Copy link
Member

SUMMARY

Not sure all the actions bumps are needed, but I'll just aim high and hope we can get everything updated.

This does NOT bump the websocket app or docs to Node 18.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added dependencies:npm github_actions Pull requests that update GitHub Actions code labels Feb 22, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.72%. Comparing base (ad7bd09) to head (6d21271).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #27198      +/-   ##
==========================================
+ Coverage   67.46%   69.72%   +2.25%     
==========================================
  Files        1910     1910              
  Lines       74802    74458     -344     
  Branches     8345     8345              
==========================================
+ Hits        50468    51913    +1445     
+ Misses      22283    20494    -1789     
  Partials     2051     2051
Flag Coverage Δ
javascript 57.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas rusackas added review-after-release Indicates that a release is in progress and that this PR might be reviewed later and removed review-after-release labels Feb 22, 2024
mistercrunch
mistercrunch approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after hold is removed

@rusackas
Copy link
Member Author

@michael-s-molina any objection to merging this now? We have these warnings cropping up, which makes me almost tempted to call this a "fix" rather than a "chore". It's non-blocking for 4.0 and doesn't need to be cherried, necessarily. But I also don't want to rock the boat on your release :)

image

@michael-s-molina
Copy link
Member

My only concern is this causing bugs on master which will be reported as issues and we'll need to check if they happen on 4.0. If you think the probability of new bugs is low then go ahead and merge it.

@rusackas rusackas mentioned this pull request Mar 19, 2024
Closed
@rusackas
Copy link
Member Author

All conflicts resolved... hopefully we can merge this soon :D

@mistercrunch
Copy link
Member

cleaning

@rusackas rusackas merged commit 5603453 into master Apr 2, 2024
32 checks passed
@rusackas rusackas deleted the node-18 branch April 2, 2024 22:48
@rusackas rusackas removed the review-after-release Indicates that a release is in progress and that this PR might be reviewed later label Apr 2, 2024
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request Apr 4, 2024
@rusackas @jzhao62
chore(node): bumping Superset to Node 18 (apache#27198)
6e29a69
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
@rusackas @EandrewJones
chore(node): bumping Superset to Node 18 (apache#27198)
09bd37f
This was referenced Apr 9, 2024
Merged
Merged
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
@rusackas @EnxDev
chore(node): bumping Superset to Node 18 (apache#27198)
09949a0
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@rusackas @qleroy
chore(node): bumping Superset to Node 18 (apache#27198)
9c393ae
@eschutho
Copy link
Member

@rusackas It looks like npm 9+ use lockfile version 3, so I also updated that check here:
https://github.com/apache/superset/pull/29723/files

@eschutho eschutho mentioned this pull request Jul 27, 2024
Closed
9 tasks
zhangvi7 pushed a commit to pinterest/superset that referenced this pull request Aug 14, 2024
@rusackas @zhangvi7
chore(node): bumping Superset to Node 18 (apache#27198)
9eb6b47
zhangvi7 added a commit to pinterest/superset that referenced this pull request Aug 14, 2024
@zhangvi7 @rusackas
Upgrade the puppeteer package to v22 and node 18 (#31)
6804e72 
* chore(node): bumping Superset to Node 18 (apache#27198)

* upgrade the puppeteer package to v22

---------

Co-authored-by: Evan Rusackas <evan@preset.io>
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@rusackas
chore(node): bumping Superset to Node 18 (apache#27198)
c129ccf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@geido geido Awaiting requested review from geido geido is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley john-bodley is a code owner

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

@dpgaspar dpgaspar Awaiting requested review from dpgaspar dpgaspar is a code owner

Assignees
No one assigned
Labels
dependencies:npm github_actions Pull requests that update GitHub Actions code size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rusackas @michael-s-molina @mistercrunch @eschutho @john-bodley