Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(viz picker): Remove some tags, refactor Recommended section #27708

Merged
merged 4 commits into from
Apr 3, 2024
Merged

feat(viz picker): Remove some tags, refactor Recommended section #27708

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3763903
feat(viz picker): Remove some tags, refactor Recommended section
kgabryje Mar 27, 2024
cbb9e2e
Update margin
kgabryje Mar 27, 2024
c5fef8f
Fix tests
kgabryje Mar 27, 2024
1f00e8a
Update icon
kgabryje Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
  • Loading branch information
@kgabryje
kgabryje committed Apr 3, 2024
commit c5fef8fb8d5201fb6ed12c2736245657e6d818a7
6 changes: 5 additions & 1 deletion superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,11 @@ export default function VizTypeGallery(props: VizTypeGalleryProps) {
if (activeSelector === ALL_CHARTS && activeSection === Sections.AllCharts) {
return sortedMetadata;
}
if (activeSelector === FEATURED && activeSection === Sections.Featured) {
if (
activeSelector === FEATURED &&
activeSection === Sections.Featured &&
chartsByTags[t('Popular')]
) {
return chartsByTags[t('Popular')];
}
if (
Expand Down