feat(viz picker): Remove some tags, refactor Recommended section

[kgabryje]

SUMMARY

Implements changes from discussion #27557

1. Remove the Recommended tags section and move the charts in "Popular" to a "Featured" section underneath All Charts, "Featured" is selected by default
2. Remove the following tags:

• Aesthetic
• Coordinates
• Deprecated
• Description
• Discrete
• Experimental
• Vertical

3. Bar Chart (legacy) : Remove Popular/Featured tag from Bar Chart (legacy)
4. Collapse Tags section by default

Also, refactored the svg icons used in viz picker (ballot, category, tags) as their viewboxes were weird, which resulted in additional css used to make them look good

CC @yousoph

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

Open the viz picker, verify that Recommended section is gone and Featured contains all charts with "Popular" tag, verify that everything looks good

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 69.77%. Comparing base (349e496) to head (0d8d05d).
Report is 3 commits behind head on master.

Files	Patch %	Lines
...ponents/controls/VizTypeControl/VizTypeGallery.tsx	77.77%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #27708      +/-   ##
==========================================
- Coverage   69.77%   69.77%   -0.01%     
==========================================
  Files        1911     1911              
  Lines       75056    75061       +5     
  Branches     8362     8364       +2     
==========================================
+ Hits        52374    52376       +2     
- Misses      20630    20631       +1     
- Partials     2052     2054       +2     

Flag	Coverage Δ
javascript	57.48% <77.77%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yousoph]

/testenv up

[github-actions]

@yousoph Ephemeral environment spinning up at http://35.93.231.29:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[michael-s-molina]

Thank you for the improvement @kgabryje!

My only non-blocking comment would be to replace the Featured icon with a ⭐

[kgabryje]

My only non-blocking comment would be to replace the Featured icon with a ⭐

@yousoph @kasiazjc wdyt?

[kasiazjc]

My only non-blocking comment would be to replace the Featured icon with a ⭐

@yousoph @kasiazjc wdyt?

@michael-s-molina also thought about ⭐️ at first, but we already use it for "favorites", so wanted to avoid duplicates. Sadly ant-d doesnt have the best choice for icons, but the other contenders (besides pin) would be:

or just

Thoughts @kgabryje @michael-s-molina ?

[kgabryje]

The first one looks good!

[michael-s-molina]

@kasiazjc The first one works. There's also:

I'll let you make the call 😉

[kasiazjc]

@kasiazjc The first one works. There's also:

I'll let you make the call 😉

Actually I think fire works well 🔥
Cc: @kgabryje

[kgabryje]

@kasiazjc @michael-s-molina Looks pretty good 🙂

[michael-s-molina]

Thank you! 🔥

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.