Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ssh tunneling to dynamic form for Database Connection UI #22689

Merged
merged 161 commits into from
Jan 20, 2023
Merged

feat: add ssh tunneling to dynamic form for Database Connection UI #22689

merged 161 commits into from
Jan 20, 2023

Commits on Oct 19, 2022

  1. save

    @hughhhh
    hughhhh committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    830a283 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. create migration

    @hughhhh
    hughhhh committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    2c1e736 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. created schema and rename

    @hughhhh
    hughhhh committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    f78df83 View commit details
    Browse the repository at this point in the history

  2. linting

    @hughhhh
    hughhhh committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    d482df4 View commit details
    Browse the repository at this point in the history

  3. fix encrpytions

    @hughhhh
    hughhhh committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    9edb581 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. remove map tabl

    @hughhhh
    hughhhh committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    da27d8f View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. fix linting

    @hughhhh
    hughhhh committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    773a6c8 View commit details
    Browse the repository at this point in the history

  2. add constraint

    @hughhhh
    hughhhh committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    2f2dda2 View commit details
    Browse the repository at this point in the history

  3. add fk to migration

    @hughhhh
    hughhhh committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    fd0d7f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. init

    @hughhhh
    hughhhh committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    158da8d View commit details
    Browse the repository at this point in the history

  2. update all the examples

    @hughhhh
    hughhhh committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    face73f View commit details
    Browse the repository at this point in the history

  3. change remaining bits

    @hughhhh
    hughhhh committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    95d079e View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. add id

    @hughhhh
    hughhhh committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    d5926e3 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. use factory instead

    @hughhhh
    hughhhh committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    f7a6a41 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/apache/superset into crea… 

    …te-sshtunnelconfig-tbl
    @hughhhh
    hughhhh committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    30e380a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into ref-get-sqla-engine-2

    @hughhhh
    hughhhh authored Oct 28, 2022
    Configuration menu
    Copy the full SHA
    87c0d79 View commit details
    Browse the repository at this point in the history

  4. fix confict

    @hughhhh
    hughhhh committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    11b240b View commit details
    Browse the repository at this point in the history

  5. fix conflict

    @hughhhh
    hughhhh committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    1bfdbda View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. setup return value for contextmanager

    @hughhhh
    hughhhh committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    4146d5a View commit details
    Browse the repository at this point in the history

  2. add sshtunnel pip

    @hughhhh
    hughhhh committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    f8b877d View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. updates test

    @hughhhh
    hughhhh committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    54fc147 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. fix linting

    @hughhhh
    hughhhh committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    fdc6ca3 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. renaming function

    @hughhhh
    hughhhh committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    66c0801 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2022

  1. fix test

    @hughhhh
    hughhhh committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    1f9ec5e View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Merge branch 'ref-get-sqla-engine-2' of https://github.com/apache/sup… 

    …erset into create-sshtunnelconfig-tbl
    @hughhhh
    hughhhh committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    c698cf4 View commit details
    Browse the repository at this point in the history

  2. add schema to test_connection api

    @hughhhh
    hughhhh committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    41bd19b View commit details
    Browse the repository at this point in the history

  3. fix get engine to return contextmanager

    @hughhhh
    hughhhh committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    8811a99 View commit details
    Browse the repository at this point in the history

  4. why

    @hughhhh
    hughhhh committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    82d7532 View commit details
    Browse the repository at this point in the history

  5. yerp

    @hughhhh
    hughhhh committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    1f829ac View commit details
    Browse the repository at this point in the history

  6. update typing

    @hughhhh
    hughhhh committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    d53d116 View commit details
    Browse the repository at this point in the history

  7. update comment

    @hughhhh
    hughhhh committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    752161d View commit details
    Browse the repository at this point in the history

  8. Merge branch 'ref-get-sqla-engine-2' of https://github.com/apache/sup… 

    …erset into create-sshtunnelconfig-tbl
    @hughhhh
    hughhhh committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    8c4b081 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. save

    @hughhhh
    hughhhh committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    1a19a97 View commit details
    Browse the repository at this point in the history

  2. save

    @hughhhh
    hughhhh committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    58b9cce View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/apache/superset into ref-… 

    …get-sqla-engine-2
    @hughhhh
    hughhhh committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    0ac6fb1 View commit details
    Browse the repository at this point in the history

  4. fix pylint

    @hughhhh
    hughhhh committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    31f3c1d View commit details
    Browse the repository at this point in the history

  5. Merge branch 'ref-get-sqla-engine-2' of https://github.com/apache/sup… 

    …erset into create-sshtunnelconfig-tbl
    @hughhhh
    hughhhh committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    a0b30e6 View commit details
    Browse the repository at this point in the history

  6. last one

    @hughhhh
    hughhhh committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    e089a8d View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. Merge branch 'ref-get-sqla-engine-2' of https://github.com/apache/sup… 

    …erset into create-sshtunnelconfig-tbl
    @hughhhh
    hughhhh committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    81b2f88 View commit details
    Browse the repository at this point in the history

  2. update naming on ssh tunnel

    @hughhhh
    hughhhh committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    45686b7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into ref-get-sqla-engine-2

    @hughhhh
    hughhhh authored Nov 9, 2022
    Configuration menu
    Copy the full SHA
    7ce5836 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'ref-get-sqla-engine-2' of https://github.com/apache/sup… 

    …erset into create-sshtunnelconfig-tbl
    @hughhhh
    hughhhh committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    d9c8d0d View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. fix renaming

    @hughhhh
    hughhhh committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    ec27b80 View commit details
    Browse the repository at this point in the history

  2. fix renaming 2

    @hughhhh
    hughhhh committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    65e3e29 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/apache/superset into crea… 

    …te-sshtunnelconfig-tbl
    @hughhhh
    hughhhh committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    9fa9db5 View commit details
    Browse the repository at this point in the history

  4. oops

    @hughhhh
    hughhhh committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    1a11ff4 View commit details
    Browse the repository at this point in the history

  5. fix linting errors

    @hughhhh
    hughhhh committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    3f0dae1 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. feat(ssh_tunnel): DAO Changes for SSH Tunnel (#22120)

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez authored Nov 15, 2022
    Configuration menu
    Copy the full SHA
    2777807 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. fix merge conflicts

    @hughhhh
    hughhhh committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    8ed02cd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'create-sshtunnelconfig-tbl' of https://github.com/apach… 

    …e/superset into create-sshtunnelconfig-tbl
    @hughhhh
    hughhhh committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    6a68147 View commit details
    Browse the repository at this point in the history

  3. feat(ssh_tunnel): Delete command & exceptions (#22131)

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    6bd32e8 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of https://github.com/apache/superset into crea… 

    …te-sshtunnelconfig-tbl
    @hughhhh
    hughhhh committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    8a3ee35 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'create-sshtunnelconfig-tbl' of https://github.com/apach… 

    …e/superset into create-sshtunnelconfig-tbl
    @hughhhh
    hughhhh committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    bc89194 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. fix indenting for superset/databases/commands/validate.py

    @hughhhh
    hughhhh committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    adb9451 View commit details
    Browse the repository at this point in the history

  2. change tablename

    @hughhhh
    hughhhh committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    16d960b View commit details
    Browse the repository at this point in the history

  3. feat(ssh_tunnel): DELETE SSH Tunnels API (#22153)

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez authored Nov 17, 2022
    Configuration menu
    Copy the full SHA
    d2ab4a6 View commit details
    Browse the repository at this point in the history

  4. Revert "feat(ssh_tunnel): DELETE SSH Tunnels API" (#22156)

    @hughhhh
    hughhhh authored Nov 17, 2022
    Configuration menu
    Copy the full SHA
    fb2acd0 View commit details
    Browse the repository at this point in the history

  5. feat(ssh_tunnel): Update command & exceptions (#22132)

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez authored Nov 17, 2022
    Configuration menu
    Copy the full SHA
    4d807c9 View commit details
    Browse the repository at this point in the history

  6. forgot server_port

    @hughhhh
    hughhhh committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    dc0c848 View commit details
    Browse the repository at this point in the history

  7. bind_port + bind_host :)

    @hughhhh
    hughhhh committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    21fcdf0 View commit details
    Browse the repository at this point in the history

  8. oops

    @hughhhh
    hughhhh committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    68cb75f View commit details
    Browse the repository at this point in the history

  9. fix linting

    @hughhhh
    hughhhh committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    44ca56b View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. feat(ssh_tunnel): SSH Tunnel updates from Code Review (#22182)

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez authored Nov 21, 2022
    Configuration menu
    Copy the full SHA
    7e1461e View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. Merge branch 'master' of https://github.com/apache/superset into crea… 

    …te-sshtunnelconfig-tbl
    @hughhhh
    hughhhh committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    92e41f1 View commit details
    Browse the repository at this point in the history

  2. feat(ssh_tunnel): Create command & exceptions (#22148)

    @hughhhh
    hughhhh authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    6c59663 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Update schemas.py

    @hughhhh
    hughhhh authored Nov 28, 2022
    Configuration menu
    Copy the full SHA
    466703a View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Merge branch 'master' of https://github.com/apache/superset into crea… 

    …te-sshtunnelconfig-tbl
    @hughhhh
    hughhhh committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    554de53 View commit details
    Browse the repository at this point in the history

  2. chore(ssh-tunnel): create contextmanager for sql.inspect (#22251)

    @hughhhh
    hughhhh authored Nov 30, 2022
    Configuration menu
    Copy the full SHA
    4448739 View commit details
    Browse the repository at this point in the history

  3. fix lint

    @hughhhh
    hughhhh committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    bb78055 View commit details
    Browse the repository at this point in the history

  4. fix migrations

    @hughhhh
    hughhhh committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    f507385 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. Merge branch 'master' of https://github.com/apache/superset into crea… 

    …te-sshtunnelconfig-tbl
    @hughhhh
    hughhhh committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    45aa022 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/apache/superset into crea… 

    …te-sshtunnelconfig-tbl
    @hughhhh
    hughhhh committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    3d3b71b View commit details
    Browse the repository at this point in the history

  3. Revert "chore(ssh-tunnel): create contextmanager for sql.inspect (#… 

    …22251)"

This reverts commit 4448739.
    @hughhhh
    hughhhh committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    86436b6 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. debugging

    @hughhhh
    hughhhh committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    54a8d7f View commit details
    Browse the repository at this point in the history

  2. fix(ssh_tunnel): Address Base PR comments from peer review (#22306)

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez authored Dec 5, 2022
    Configuration menu
    Copy the full SHA
    3f6afec View commit details
    Browse the repository at this point in the history

  3. fix pre-commit

    @hughhhh
    hughhhh committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    7625566 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. working changes

    @hughhhh
    hughhhh committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    0578a8e View commit details
    Browse the repository at this point in the history

  2. refactor bind_host and bind_port

    @hughhhh
    hughhhh committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    ec20429 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. refactor create flow for temp ssh tunnels

    @hughhhh
    hughhhh committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    1f57d4a View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. remove logger

    @hughhhh
    hughhhh committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    ed19a3e View commit details
    Browse the repository at this point in the history

  2. chore(ssh_tunnel): Add extra tests to SSHTunnel commands (#22372)

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez authored Dec 8, 2022
    Configuration menu
    Copy the full SHA
    852c8bb View commit details
    Browse the repository at this point in the history

  3. add flush to allow database.id to be populated

    @hughhhh
    hughhhh committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    be5c005 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'create-sshtunnelconfig-tbl' of https://github.com/apach… 

    …e/superset into create-sshtunnelconfig-tbl
    @hughhhh
    hughhhh committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    948f748 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. make sure to use inspector with context

    @hughhhh
    hughhhh committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    c636ce7 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. remove id and database_id

    @hughhhh
    hughhhh committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    908896f View commit details
    Browse the repository at this point in the history

  2. uselist

    @hughhhh
    hughhhh committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    e3ef835 View commit details
    Browse the repository at this point in the history

  3. refactor bind_host and bind_port

    @hughhhh @Antonio-RiveroMartnez
    hughhhh authored and Antonio-RiveroMartnez committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    a4b1c28 View commit details
    Browse the repository at this point in the history

  4. debugging

    @hughhhh @Antonio-RiveroMartnez
    hughhhh authored and Antonio-RiveroMartnez committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    828d45c View commit details
    Browse the repository at this point in the history

  5. SSH Tunnel: 

    - Initial DELETE and CREATE ssh tunnel APIs
- Add happy path tests for each API

NOTE:
- Updating a DB might also result in creating a Tunnel, that flow will get tested in the UPDATE API changes.
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    862288a View commit details
    Browse the repository at this point in the history

  6. SSH Tunnel: 

    - Uncomment ssh tunnel creation for TestConnection command
- Update our tests
- Add update changes in API
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    5ca158e View commit details
    Browse the repository at this point in the history

  7. SSH Tunnel: 

    - Adjust our tests so it's clear our endpoint uses PATCH and not PUT
- Add delete cascading test: When deleting a database, the tunnel should be deleted
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    ade44d3 View commit details
    Browse the repository at this point in the history

  8. SSH Tunnel: 

    - Add not found test when deleting the tunnel
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    bae36a0 View commit details
    Browse the repository at this point in the history

  9. SSH Tunnel: 

    - FIx linting errors
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    e3f99d2 View commit details
    Browse the repository at this point in the history

  10. SSH Tunnel: 

    - Fix pre-commit errors
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    6641f97 View commit details
    Browse the repository at this point in the history

  11. SSH Tunnel: 

    - Remove bind properties from schema used in TestConnection
- Add test for SSH Tunnel failure and no DB creation
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    c7dc836 View commit details
    Browse the repository at this point in the history

  12. SSH Tunnel: 

    - Make server_address, server_port and username required fields for our SSHTunnel schema
- Update the tests so we can consider new message with required fields
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    89c20eb View commit details
    Browse the repository at this point in the history

  13. SSH Tunnel: 

    - Changes from Code review feedback
- Solve conflict with base branch
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    f4b34a2 View commit details
    Browse the repository at this point in the history

  14. SSH Tunnel: 

    - Remove safe decorator so SIP-41 errors can be returned
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    ce842a6 View commit details
    Browse the repository at this point in the history

  15. SSH Tunnel: 

    - Fix update tests
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    3ae8c86 View commit details
    Browse the repository at this point in the history

  16. SSH Tunnel: 

    - Mask passwords for SSH when creating a new one
- Fix arg name in test connection
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    3faf78c View commit details
    Browse the repository at this point in the history

  17. SSH Tunnel: 

    - Use SSHTunnel commands instead of DAOs
- Update tests
- Fix linting and pre-commit
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    66fb789 View commit details
    Browse the repository at this point in the history

  18. SSH Tunnel: 

    - Flush only if creating a ssh tunnel
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    cc243bf View commit details
    Browse the repository at this point in the history

  19. SSH Tunnel: 

    - Do not return passwords for SSH Tunnel in any API call
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    8e910f1 View commit details
    Browse the repository at this point in the history

  20. SSH Tunnel: 

    - Using nested transactions so we can rollback if anything fails
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    a5cf0e4 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. feat(ssh-tunnel): ssh manager config + feature flag (#22201)

    @hughhhh
    hughhhh authored Dec 15, 2022
    Configuration menu
    Copy the full SHA
    c5c50ed View commit details
    Browse the repository at this point in the history

  2. update kwarg function name

    @hughhhh
    hughhhh committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    06e115b View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. chore(ssh-tunnel): Move SSHManager to extensions pattern (#22433)

    @hughhhh
    hughhhh authored Dec 16, 2022
    Configuration menu
    Copy the full SHA
    13ed50d View commit details
    Browse the repository at this point in the history

  2. add flag to indicate ssh tunneling is enabled for this engine

    @hughhhh
    hughhhh committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    54d51e2 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Update superset/migrations/versions/2022-10-20_10-48_f3c2d8ec8595_cre… 

    …ate_ssh_tunnel_credentials_tbl.py

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
    @hughhhh @eschutho
    hughhhh and eschutho authored Dec 19, 2022
    Configuration menu
    Copy the full SHA
    53eaa63 View commit details
    Browse the repository at this point in the history

  2. Update superset/migrations/versions/2022-10-20_10-48_f3c2d8ec8595_cre… 

    …ate_ssh_tunnel_credentials_tbl.py

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
    @hughhhh @eschutho
    hughhhh and eschutho authored Dec 19, 2022
    Configuration menu
    Copy the full SHA
    8f8faff View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. fix linting

    @hughhhh
    hughhhh committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    607c682 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'create-sshtunnelconfig-tbl' into api_ssh_tunnel

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    367efe6 View commit details
    Browse the repository at this point in the history

  3. SSH Tunnel: 

    - Extend GET endpoint on Database APi so it includes SSH Tunnel if any
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    dffc266 View commit details
    Browse the repository at this point in the history

  4. SSH Tunnel: 

    - Initial SSH Tunnel UI: Adding SSH form to SQLA form
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    65d3fc9 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. SSH Tunnel: 

    - Handle Database edition with SSH Tunnels
- Add masked password, private_key and private_key_password to GET call so when editing a DB we can use those and unmask before updating
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    e1815da View commit details
    Browse the repository at this point in the history

  2. SSH Tunnel: 

    - Remove ssh_tunnel form DB when toggling off the config switch (opting out when creating or editing a DB w/o a tunnel)
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    e16c52b View commit details
    Browse the repository at this point in the history

  3. SSH Tunnel: 

    - Add masked values for password, private_key and private_key_password for POST and PUT endpoints
- Update our tests
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    9da6987 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2022

  1. SSH Tunnel: 

    - Fix incompatible types pre-commit error
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    110e0ba View commit details
    Browse the repository at this point in the history

  2. SSH Tunnel UI: 

    - Add new reducer action types tests
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    b328427 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/apache/superset into crea… 

    …te-sshtunnelconfig-tbl
    @hughhhh
    hughhhh committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    1ea0e8b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'create-sshtunnelconfig-tbl' into api_ssh_tunnel

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    d5b4ad2 View commit details
    Browse the repository at this point in the history

  5. Merge master into ssh_sqla_form

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    5fc7e09 View commit details
    Browse the repository at this point in the history

  6. fix requirements

    @hughhhh
    hughhhh committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    7cc7bc8 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'create-sshtunnelconfig-tbl' into api_ssh_tunnel

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    227029d View commit details
    Browse the repository at this point in the history

  8. Merge branch 'api_ssh_tunnel' into ssh_sqla_form

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    422a86e View commit details
    Browse the repository at this point in the history

  9. SSH Tunnel UI: 

    - Use SSH Tunnel only if feature flag is enabled
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    28342a4 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. Merge branch 'master' of https://github.com/apache/superset into crea… 

    …te-sshtunnelconfig-tbl
    @hughhhh
    hughhhh committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    7c539d2 View commit details
    Browse the repository at this point in the history

  2. SSH Tunnel: 

    - Add util method to mask password
- Adjust tests to consider password masking
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    643d25e View commit details
    Browse the repository at this point in the history

  3. SSH Tunnel: 

    - Remove the extra description on GET endpoint for databases
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    846815e View commit details
    Browse the repository at this point in the history

  4. get df with get_raw_connection function

    @hughhhh
    hughhhh committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    394afc1 View commit details
    Browse the repository at this point in the history

  5. SSH Tunnel: 

    - Fix pre-commit error
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    052eee1 View commit details
    Browse the repository at this point in the history

  6. feat(ssh_tunnel): APIs for SSH Tunnels (#22199) 

    Co-authored-by: hughhhh <hughmil3s@gmail.com>
    @Antonio-RiveroMartnez @hughhhh
    Antonio-RiveroMartnez and hughhhh authored Jan 3, 2023
    Configuration menu
    Copy the full SHA
    9b09fc7 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'api_ssh_tunnel' into ssh_sqla_form

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    af66b34 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'create-sshtunnelconfig-tbl' into api_ssh_tunnel

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    2bb1140 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'api_ssh_tunnel' into ssh_sqla_form

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    1170a34 View commit details
    Browse the repository at this point in the history

  10. SSH Tunnel: 

    - Fix pylint error
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    857e041 View commit details
    Browse the repository at this point in the history

  11. Merge master

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    27587ec View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. SSH Tunnel UI: 

    - Add visual test to confirm the new SSH Tunnel form fields are present if we click the toggle button
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    1cb7384 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ssh_sqla_form

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    86db39d View commit details
    Browse the repository at this point in the history

  3. SSH Tunnel UI: 

    - Add extra UI tests for our SSH Tunnel Form
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    6a03887 View commit details
    Browse the repository at this point in the history

  4. SSH Tunnel UI: 

    - Add new test to consider changing the login method used in SSH Tunnel Form
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    ff5ec7f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into ssh_sqla_form

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    213f57a View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Merge branch 'master' into ssh_sqla_form

    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    1e0161d View commit details
    Browse the repository at this point in the history

  2. SSH Tunnel UI: 

    - Hide the entire form behind the feature flag
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    e394e7a View commit details
    Browse the repository at this point in the history

  3. SSH Tunnel UI: 

    - Fix TestConnection when editing a DB with SSH Tunnel attached to it
- Add new unmask_password_info util method for SSH Tunnels
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    a096122 View commit details
    Browse the repository at this point in the history

  4. SSH Tunnel UI: 

    - Add ssh_tunnel id in our response for the GET endpoint of DB so we can call test_connection endpoint without depending on DB's name
    @Antonio-RiveroMartnez
    Antonio-RiveroMartnez committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    8df08f9 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. functionality works

    @hughhhh
    hughhhh committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    ffd9a56 View commit details
    Browse the repository at this point in the history

  2. fix styling

    @hughhhh
    hughhhh committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    ec9788d View commit details
    Browse the repository at this point in the history

  3. style changes

    @hughhhh
    hughhhh committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    3e8ae1c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of https://github.com/apache/superset into hxgh… 

    …-ssh-dynamic-form
    @hughhhh
    hughhhh committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    fa0e932 View commit details
    Browse the repository at this point in the history

  5. cast as bool

    @hughhhh
    hughhhh committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    1f5f8c0 View commit details
    Browse the repository at this point in the history

  6. casting type

    @hughhhh
    hughhhh committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    8adb25f View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. add test for dynamic form

    @hughhhh
    hughhhh committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    80628d0 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. add right postgres value

    @hughhhh
    hughhhh committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    f4b0b3a View commit details
    Browse the repository at this point in the history

  2. fix test

    @hughhhh
    hughhhh committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    032c938 View commit details
    Browse the repository at this point in the history

  3. remove logs

    @hughhhh
    hughhhh committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    c007b25 View commit details
    Browse the repository at this point in the history

  4. rename variable

    @hughhhh
    hughhhh committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    7da78fa View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/i… 

    …ndex.tsx

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
    @hughhhh @lyndsiWilliams
    hughhhh and lyndsiWilliams authored Jan 18, 2023
    Configuration menu
    Copy the full SHA
    02facfb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/apache/superset into hxgh… 

    …-ssh-dynamic-form
    @hughhhh
    hughhhh committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    cb6f761 View commit details
    Browse the repository at this point in the history

  3. fix lint

    @hughhhh
    hughhhh committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    276802f View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Merge branch 'master' of https://github.com/apache/superset into hxgh… 

    …-ssh-dynamic-form
    @hughhhh
    hughhhh committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    830b787 View commit details
    Browse the repository at this point in the history