Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssh_tunnel): Address Base PR comments from peer review #22306

Conversation

Antonio-RiveroMartnez
Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez commented Dec 1, 2022

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #22306 (d24786f) into create-sshtunnelconfig-tbl (3d3b71b) will decrease coverage by 0.17%.
The diff coverage is 50.00%.

❗ Current head d24786f differs from pull request most recent head 882477e. Consider uploading reports for the commit 882477e to get more accurate results

@@                      Coverage Diff                       @@
##           create-sshtunnelconfig-tbl   #22306      +/-   ##
==============================================================
- Coverage                       55.77%   55.59%   -0.18%     
==============================================================
  Files                            1852     1852              
  Lines                           70473    70461      -12     
  Branches                         7689     7689              
==============================================================
- Hits                            39303    39174     -129     
- Misses                          29176    29293     +117     
  Partials                         1994     1994              
Flag Coverage Δ
hive ?
presto 52.34% <40.47%> (-0.14%) ⬇️
python 57.56% <50.00%> (-0.37%) ⬇️
unit 51.04% <47.61%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/models/core.py 76.32% <26.92%> (-0.15%) ⬇️
superset/databases/ssh_tunnel/models.py 77.41% <80.00%> (+0.75%) ⬆️
superset/constants.py 100.00% <100.00%> (ø)
superset/databases/commands/test_connection.py 64.47% <100.00%> (+2.27%) ⬆️
superset/databases/schemas.py 85.47% <100.00%> (+0.09%) ⬆️
superset/databases/ssh_tunnel/commands/create.py 90.47% <100.00%> (-0.83%) ⬇️
superset/databases/ssh_tunnel/commands/update.py 88.00% <100.00%> (-0.47%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 34.38% <0.00%> (-30.44%) ⬇️
superset/connectors/sqla/utils.py 77.66% <0.00%> (-2.92%) ⬇️
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Antonio-RiveroMartnez Antonio-RiveroMartnez requested a review from a team as a code owner December 1, 2022 20:27
- Fix linting
@hughhhh hughhhh force-pushed the create-sshtunnelconfig-tbl branch 2 times, most recently from b25ff51 to edfa155 Compare December 2, 2022 01:05
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Antonio-RiveroMartnez. Looks great!

@rusackas
Copy link
Member

rusackas commented Dec 2, 2022

Re-running CI... will merge if it passes 🤞

@eschutho eschutho merged commit 3f6afec into apache:create-sshtunnelconfig-tbl Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants