-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ssh_tunnel): Address Base PR comments from peer review #22306
fix(ssh_tunnel): Address Base PR comments from peer review #22306
Conversation
- Address code reviews comments: apache#21912 (comment) apache#21912 (comment) apache#21912 (comment) apache#21912 (comment) apache#21912 (comment)
Codecov Report
@@ Coverage Diff @@
## create-sshtunnelconfig-tbl #22306 +/- ##
==============================================================
- Coverage 55.77% 55.59% -0.18%
==============================================================
Files 1852 1852
Lines 70473 70461 -12
Branches 7689 7689
==============================================================
- Hits 39303 39174 -129
- Misses 29176 29293 +117
Partials 1994 1994
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
- Fix linting
- Use sa.Column(sa.Text) instead of sa.Column(sa.String) for some fields
b25ff51
to
edfa155
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @Antonio-RiveroMartnez. Looks great!
Re-running CI... will merge if it passes 🤞 |
edfa155
to
54a8d7f
Compare
SUMMARY
Address code reviews comments:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION