-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): Add correct icon, label and badge to horizontal native filters dropdown button #22211
Conversation
b0aab8d
to
9ab5bed
Compare
Codecov Report
@@ Coverage Diff @@
## master #22211 +/- ##
==========================================
- Coverage 66.91% 66.84% -0.08%
==========================================
Files 1839 1841 +2
Lines 70079 70220 +141
Branches 7636 7670 +34
==========================================
+ Hits 46894 46936 +42
- Misses 21218 21302 +84
- Partials 1967 1982 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
9ab5bed
to
f5858f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 bug to address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I pushed a fix for the issue with empty content in the dropdown. Now the dropdown button won't display if the menu is empty
- Not really related to this PR, but after discussion with @kasiazjc I removed the style overrides for
Add/Edit filter
button in horizontal mode. It was implemented as in designs, but it was inconsistent with the vertical version. Now both vertical and horizontal buttons look the same.
SUMMARY
This PR is based on #22169 and fixes some issues with the native filters dropdown button:
Note: there are still some issues with getting the component to resize correctly, but those will be addressed in a future PR.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
HORIZONTAL_FILTER_BAR