Fix dropdown button displaying when there's no content inside

apache · Nov 28, 2022 · b0046fb · b0046fb
1 parent ae66da8
commit b0046fb
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/...ontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx b/...ontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx
@@ -156,14 +156,19 @@ const FilterControls: FC<FilterControlsProps> = ({
         }
         dropdownTriggerText={t('More filters')}
         dropdownTriggerCount={activeOverflowedFiltersInScope}
-        dropdownContent={() => (
-          <FiltersDropdownContent
-            filtersInScope={overflowedFiltersInScope}
-            filtersOutOfScope={filtersOutOfScope}
-            renderer={renderer}
-            showCollapsePanel={showCollapsePanel}
-          />
-        )}
+        dropdownContent={
+          overflowedFiltersInScope.length ||
+          (filtersOutOfScope.length && showCollapsePanel)
+            ? () => (
+                <FiltersDropdownContent
+                  filtersInScope={overflowedFiltersInScope}
+                  filtersOutOfScope={filtersOutOfScope}
+                  renderer={renderer}
+                  showCollapsePanel={showCollapsePanel}
+                />
+              )
+            : undefined
+        }
         onOverflowingStateChange={({ overflowed: nextOverflowedIds }) => {
           if (
             nextOverflowedIds.length !== overflowedIds.length ||