Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dataset exists error in save Dataset modal #21244

Merged
merged 2 commits into from
Aug 31, 2022
Merged

fix: dataset exists error in save Dataset modal #21244

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1961582
dataset exists error
AAfghahi Aug 29, 2022
5ba0d51
fixed flashing modal
AAfghahi Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion superset-frontend/src/SqlLab/actions/sqlLab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1425,7 +1425,10 @@ export function createDatasource(vizOptions) {

return Promise.resolve(json);
})
.catch(() => {
.catch(error => {
getClientErrorObject(error).then(e => {
dispatch(addDangerToast(e.error));
});
dispatch(
createDatasourceFailed(
t('An error occurred while creating the data source'),
Expand Down
2 changes: 2 additions & 0 deletions superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,9 +307,11 @@ export const SaveDatasetModal: FunctionComponent<SaveDatasetModalProps> = ({
})
.catch(() => {
addDangerToast(t('An error occurred saving dataset'));
onHide();
});

setDatasetName(getDefaultDatasetName());
console.log(formData);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup removed.

onHide();
};

Expand Down