fix: dataset exists error in save Dataset modal

[AAfghahi]

SUMMARY

When a user tried to create a dataset with an already existing name, the current SaveDatasetModal was soft failing. This adds a danger toast to the action that creates datasources.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-08-29.at.5.03.19.PM.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #21244 (5ba0d51) into master (8772e2c) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #21244      +/-   ##
==========================================
- Coverage   66.43%   66.42%   -0.01%     
==========================================
  Files        1784     1784              
  Lines       68163    68280     +117     
  Branches     7264     7307      +43     
==========================================
+ Hits        45285    45356      +71     
- Misses      21010    21047      +37     
- Partials     1868     1877       +9     

Flag	Coverage Δ
hive	53.03% <ø> (ø)
javascript	52.46% <0.00%> (-0.04%)	⬇️
mysql	80.87% <ø> (?)
postgres	80.93% <ø> (+0.01%)	⬆️
presto	52.93% <ø> (ø)
python	81.40% <ø> (+0.05%)	⬆️
sqlite	79.44% <ø> (ø)
unit	50.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js	61.05% <0.00%> (-0.33%)	⬇️
...d/src/SqlLab/components/SaveDatasetModal/index.tsx	52.87% <0.00%> (ø)
...ols/DndColumnSelectControl/ColumnSelectPopover.tsx	2.85% <0.00%> (-0.41%)	⬇️
superset/reports/commands/execute.py	91.54% <0.00%> (+0.35%)	⬆️
superset/views/core.py	75.60% <0.00%> (+0.45%)	⬆️
superset/common/query_object.py	94.38% <0.00%> (+0.51%)	⬆️
superset/models/core.py	88.88% <0.00%> (+0.70%)	⬆️
superset/commands/importers/v1/utils.py	93.50% <0.00%> (+1.29%)	⬆️
superset/reports/commands/log_prune.py	89.28% <0.00%> (+3.57%)	⬆️
...tend/src/views/CRUD/data/database/DatabaseList.tsx	72.12% <0.00%> (+3.75%)	⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[hughhhh]

remove this

[AAfghahi]

yup removed.

[hughhhh]

remove the console.log

[geido]

@AAfghahi from the video it appears that the modals close and reopen when the error occurs. It does not look ideal for the end user. How hard would it be to wait for the response and then only close the modal when successful and leave it open when unsuccessful? This would avoid the quick close-reopen behaviour currently shown in the video.

Also, I am not sure if it makes more sense to show this error inline in the form? @kasiazjc what you think?

[kasiazjc]

@AAfghahi from the video it appears that the modals close and reopen when the error occurs. It does not look ideal for the end user. How hard would it be to wait for the response and then only close the modal when successful and leave it open when unsuccessful? This would avoid the quick close-reopen behaviour currently shown in the video.

Also, I am not sure if it makes more sense to show this error inline in the form? @kasiazjc what you think?

Definitely agree with @geido. Errors should be shown in context, so it would be better to use inline info type. Toast can be easily missed by the user and this pattern is not intuitive.

[AAfghahi]

@AAfghahi from the video it appears that the modals close and reopen when the error occurs. It does not look ideal for the end user. How hard would it be to wait for the response and then only close the modal when successful and leave it open when unsuccessful? This would avoid the quick close-reopen behaviour currently shown in the video.

Also, I am not sure if it makes more sense to show this error inline in the form? @kasiazjc what you think?

Hey, yeah I am working on that portion right now!

[AAfghahi]

@geido Fixed in latest.

Screen.Recording.2022-08-30.at.11.09.43.AM.mov

[yousoph]

@AAfghahi from the video it appears that the modals close and reopen when the error occurs. It does not look ideal for the end user. How hard would it be to wait for the response and then only close the modal when successful and leave it open when unsuccessful? This would avoid the quick close-reopen behaviour currently shown in the video.
Also, I am not sure if it makes more sense to show this error inline in the form? @kasiazjc what you think?

Definitely agree with @geido. Errors should be shown in context, so it would be better to use inline info type. Toast can be easily missed by the user and this pattern is not intuitive.

Inline makes sense to me! We'll plan to do that as a follow up so we can at least give the user some feedback first while we work on improving the display of the message.

[AAfghahi]

/testenv up

[github-actions]

@AAfghahi Ephemeral environment spinning up at http://35.92.135.26:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[jinghua-qa]

LGTM

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.