-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Added "kind" to dataset/<pk> endpoint #20113
feat(api): Added "kind" to dataset/<pk> endpoint #20113
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20113 +/- ##
==========================================
- Coverage 66.46% 66.43% -0.04%
==========================================
Files 1721 1724 +3
Lines 64467 64687 +220
Branches 6795 6795
==========================================
+ Hits 42847 42972 +125
- Misses 19892 19987 +95
Partials 1728 1728
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you!
Hi @reesercollins, the CI was stuck in the code format. Could you fix it? Thanks. |
SUMMARY
The “kind” field is already returned by the main dataset GET endpoint. Having the “kind” field returned by the dataset/ endpoint is needed for external services.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Perform a GET request on the /api/v1/dataset/ endpoint.
ADDITIONAL INFORMATION