Skip to content

Commit

Permalink
feat(api): Added "kind" to dataset/<pk> endpoint (#20113)
Browse files Browse the repository at this point in the history
  • Loading branch information
reesercollins authored Jun 10, 2022
1 parent 1918dc0 commit 11b33de
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions docs/static/resources/openapi.json
Original file line number Diff line number Diff line change
Expand Up @@ -4399,6 +4399,9 @@
"nullable": true,
"type": "boolean"
},
"kind": {
"readOnly": true
},
"main_dttm_col": {
"maxLength": 250,
"nullable": true,
Expand Down
1 change: 1 addition & 0 deletions superset/datasets/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ class DatasetRestApi(BaseSupersetModelRestApi):
"datasource_type",
"url",
"extra",
"kind",
]
show_columns = show_select_columns + [
"columns.type_generic",
Expand Down
1 change: 1 addition & 0 deletions tests/integration_tests/datasets/api_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,7 @@ def test_get_dataset_item(self):
"fetch_values_predicate": None,
"filter_select_enabled": False,
"is_sqllab_view": False,
"kind": "physical",
"main_dttm_col": None,
"offset": 0,
"owners": [],
Expand Down

0 comments on commit 11b33de

Please sign in to comment.