Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new enums for datasource types #20015

Merged
merged 1 commit into from
May 10, 2022
Merged

feat: add new enums for datasource types #20015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion superset/utils/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,16 @@ class GenericDataType(IntEnum):
# ROW = 7


class DatasourceType(Enum):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're going to want to inherit from (str, Enum) so that you can show the string representation later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're going to want to inherit from (str, Enum) so that you can show the string representation later.

SQLATABLE = "sqlatable"
TABLE = "table"
DATASET = "dataset"
QUERY = "query"
SAVEDQUERY = "saved_query"


class DatasourceDict(TypedDict):
type: str
type: str # todo(hugh): update this to be DatasourceType
id: int


Expand Down