-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new enums for datasource types #20015
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20015 +/- ##
==========================================
- Coverage 66.51% 66.13% -0.38%
==========================================
Files 1690 1712 +22
Lines 64614 63974 -640
Branches 6655 6731 +76
==========================================
- Hits 42978 42310 -668
- Misses 19936 19953 +17
- Partials 1700 1711 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -174,8 +174,16 @@ class GenericDataType(IntEnum): | |||
# ROW = 7 | |||
|
|||
|
|||
class DatasourceType(Enum): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're going to want to inherit from (str, Enum) so that you can show the string representation later.
@@ -174,8 +174,16 @@ class GenericDataType(IntEnum): | |||
# ROW = 7 | |||
|
|||
|
|||
class DatasourceType(Enum): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're going to want to inherit from (str, Enum) so that you can show the string representation later.
SUMMARY
Adding specific enum to represent the different datasource types.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION