Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new enums for datasource types #20015

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented May 10, 2022

SUMMARY

Adding specific enum to represent the different datasource types.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #20015 (0809002) into master (e061955) will decrease coverage by 0.37%.
The diff coverage is 55.01%.

❗ Current head 0809002 differs from pull request most recent head 62ad921. Consider uploading reports for the commit 62ad921 to get more accurate results

@@            Coverage Diff             @@
##           master   #20015      +/-   ##
==========================================
- Coverage   66.51%   66.13%   -0.38%     
==========================================
  Files        1690     1712      +22     
  Lines       64614    63974     -640     
  Branches     6655     6731      +76     
==========================================
- Hits        42978    42310     -668     
- Misses      19936    19953      +17     
- Partials     1700     1711      +11     
Flag Coverage Δ
hive 53.66% <ø> (+0.96%) ⬆️
mysql ?
postgres ?
presto 53.52% <ø> (+0.97%) ⬆️
python 82.15% <ø> (-0.28%) ⬇️
sqlite 81.79% <ø> (+0.02%) ⬆️
unit 48.64% <ø> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-chart-controls/src/sections/advancedAnalytics.tsx 14.28% <0.00%> (-19.05%) ⬇️
...rset-ui-chart-controls/src/sections/chartTitle.tsx 100.00% <ø> (ø)
...omponents/ColumnConfigControl/ColumnConfigItem.tsx 0.00% <ø> (ø)
.../shared-controls/components/RadioButtonControl.tsx 0.00% <ø> (ø)
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
...perset-ui-core/src/chart/components/SuperChart.tsx 100.00% <ø> (ø)
...superset-ui-core/src/query/types/PostProcessing.ts 100.00% <ø> (ø)
...ugins/legacy-plugin-chart-calendar/src/Calendar.js 0.00% <ø> (ø)
...legacy-plugin-chart-calendar/src/ReactCalendar.jsx 0.00% <0.00%> (ø)
...ns/legacy-plugin-chart-heatmap/src/controlPanel.ts 66.66% <ø> (ø)
... and 223 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e061955...62ad921. Read the comment docs.

@hughhhh hughhhh merged commit 1f0daa9 into apache:master May 10, 2022
@@ -174,8 +174,16 @@ class GenericDataType(IntEnum):
# ROW = 7


class DatasourceType(Enum):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're going to want to inherit from (str, Enum) so that you can show the string representation later.

@@ -174,8 +174,16 @@ class GenericDataType(IntEnum):
# ROW = 7


class DatasourceType(Enum):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're going to want to inherit from (str, Enum) so that you can show the string representation later.

hughhhh added a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants