-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-chart-table): Resetting controls when switching query mode #19792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the quick turnaround!
LGTM! |
Codecov Report
@@ Coverage Diff @@
## master #19792 +/- ##
=======================================
Coverage 66.53% 66.53%
=======================================
Files 1692 1692
Lines 64779 64780 +1
Branches 6660 6661 +1
=======================================
+ Hits 43102 43103 +1
Misses 19977 19977
Partials 1700 1700
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…apache#19792) (cherry picked from commit fcc8080)
🏷️ preset:2022.15 |
SUMMARY
As a result of changes in PR #19039, when user switched query mode in table chart between Aggregate and Raw Records, the controls in currently inactive mode were being reset. This PR fixes that problem by introducing a new prop
resetOnHide
, which is true by default and set to false in table chart controls.Please consider this PR as a hotfix - we should probably figure out a more sturdy, foolproof solution.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2022-04-20.at.15.12.14.mov
After:
Screen.Recording.2022-04-20.at.16.18.31.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION