fix(explore): clean data when hidding control

[stephenLYZ]

SUMMARY

This PR solves the problem that form data will not be cleared when hiding a control via dynamic controls (e.g. orderBy). These are what I did:

• Make a control whose visibility is false doesn't return null in parent component rendering, but returns null in child component and resets the control value in child component useEffect.
• Since it still renders in component trees and we need to make it behave the same as HiddenControl (don't be counted and don't display)
• Clean unused code
• Add more tests for this part

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

before.mov

after

after.mov

TESTING INSTRUCTIONS

• Create a Timeseries chart
• Add one METRIC
• Add one SORT BY
• Uncheck SORT DESCENDING
• Run query
• Remove SORT BY
• Run query
• view the query

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #19039 (a3e1ed2) into master (a59718b) will increase coverage by 0.00%.
The diff coverage is 75.00%.

❗ Current head a3e1ed2 differs from pull request most recent head 8c0ad91. Consider uploading reports for the commit 8c0ad91 to get more accurate results

@@           Coverage Diff           @@
##           master   #19039   +/-   ##
=======================================
  Coverage   66.59%   66.59%           
=======================================
  Files        1682     1682           
  Lines       64291    64299    +8     
  Branches     6554     6558    +4     
=======================================
+ Hits        42815    42823    +8     
+ Misses      19775    19774    -1     
- Partials     1701     1702    +1     

Flag	Coverage Δ
javascript	51.37% <75.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...et-ui-chart-controls/src/shared-controls/index.tsx	36.19% <ø> (ø)
...perset-frontend/src/explore/components/Control.tsx	70.00% <50.00%> (+16.15%)	⬆️
.../src/explore/components/ControlPanelsContainer.tsx	79.59% <100.00%> (-0.21%)	⬇️
...set-frontend/src/explore/components/ControlRow.tsx	100.00% <100.00%> (ø)
superset-frontend/src/profile/App.tsx	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a59718b...8c0ad91. Read the comment docs.

[stephenLYZ]

Currently we don't have ColorMapControl, so clean it here.

[zhaoyongjie]

Hi @stephenLYZ , I tested this PR in my local, but the order direction checkbox is gone when I put an ad-hoc metric.

order.direction.gone.mov

[stephenLYZ]

Hi @stephenLYZ , I tested this PR in my local, but the order direction checkbox is gone when I put an ad-hoc metric.

order.direction.gone.mov

Fixed.

[zhaoyongjie]

LGTM!