-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(native-filters): Implement filter cards #18874
Conversation
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/DependenciesRow.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/DependenciesRow.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/ScopeRow.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/ScopeRow.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/useFilterScope.ts
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/useFilterScope.ts
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/useFilterScope.ts
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/useFilterScope.ts
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/useFilterScope.ts
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/useTruncation.ts
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/useTruncation.ts
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/useTruncation.ts
Show resolved
Hide resolved
7aadac8
to
f2e18b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #18874 +/- ##
==========================================
- Coverage 66.36% 66.21% -0.16%
==========================================
Files 1621 1633 +12
Lines 63057 63210 +153
Branches 6382 6409 +27
==========================================
+ Hits 41850 41852 +2
- Misses 19547 19698 +151
Partials 1660 1660
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SUMMARY
This PR implements the Filter Card component. Please note that as of now this component is not used anywhere - usages will be added in upcoming PRs.
Filter card is a component that displays native filter's metadata in user-friendly, readable way.
Information displayed:
Filter scope values:
Filter dependencies:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
TODO: add unit tests
Manual tests will be performed when filter cards are added to filters
ADDITIONAL INFORMATION
CC @kasiazjc
https://app.shortcut.com/preset/story/36388/filter-cards