-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(native-filters): Add unit tests for filter cards #18967
Conversation
{scope.map((element, index) => ( | ||
<span>{index === 0 ? element : `, ${element}`}</span> | ||
))} | ||
{scope |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eb18ff8
to
9e6d355
Compare
Codecov Report
@@ Coverage Diff @@
## master #18967 +/- ##
==========================================
+ Coverage 66.40% 66.57% +0.17%
==========================================
Files 1641 1641
Lines 63520 63519 -1
Branches 6422 6422
==========================================
+ Hits 42178 42288 +110
+ Misses 19681 19556 -125
- Partials 1661 1675 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* chore(native-filters): Add unit tests for filter cards * Fix test (cherry picked from commit ec746c2)
SUMMARY
This PR adds unit tests for filter cards implemented in #18874
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION