Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate HiddenControl component from jsx to tsx #17315

Merged
merged 4 commits into from
Nov 2, 2021
Merged

chore: migrate HiddenControl component from jsx to tsx #17315

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2359272
migrate HiddenControl component from jsx to tsx
Damans227 Nov 1, 2021
137449a
Update superset-frontend/src/explore/components/controls/HiddenContro…
Damans227 Nov 1, 2021
f520134
updating the type of value in the interface
Damans227 Nov 2, 2021
193a7d3
Update superset-frontend/src/explore/components/controls/HiddenContro…
Damans227 Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 5 additions & 20 deletions ...ore/components/controls/HiddenControl.jsx → ...ore/components/controls/HiddenControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,29 +17,14 @@
* under the License.
*/
import React from 'react';
import PropTypes from 'prop-types';
import { Input } from 'src/common/components';

const propTypes = {
onChange: PropTypes.func,
value: PropTypes.oneOfType([
PropTypes.string,
PropTypes.number,
PropTypes.object,
PropTypes.bool,
PropTypes.array,
PropTypes.func,
]),
};

const defaultProps = {
onChange: () => {},
};
interface HiddenControlsProps {
onChange: () => void;
value: string | number | readonly string[] | undefined;
}

export default function HiddenControl(props) {
export default function HiddenControl(props: HiddenControlsProps) {
// This wouldn't be necessary but might as well
return <Input type="hidden" value={props.value} />;
}

HiddenControl.propTypes = propTypes;
HiddenControl.defaultProps = defaultProps;