chore: migrate HiddenControl component from jsx to tsx

[Damans227]

SUMMARY

PR for migrating HiddenControl functional react component from JSX to TSX

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue: [TRACKER] Migrate JavaScript files to TypeScript [TRACKER] Migrate JavaScript files to TypeScript #10004
• Enhancement (new features, refinement)
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[Damans227]

@etr2460 Ptal, thanks!

[etr2460]

@Damans227 looks like there's a couple lint issues here. I'd recommend running npm run type locally to see the typescript errors, and also updating the pr title according to the PR Lint error here

[Damans227]

@Damans227 looks like there's a couple lint issues here. I'd recommend running npm run type locally to see the typescript errors, and also updating the pr title according to the PR Lint error here

@etr2460 Looks like there is a type mismatch:

src/explore/components/controls/HiddenControl.tsx:29:31 - error TS2322: Type 'string | number | boolean | Function | any[] | Record<string, any>' is not assignable to type 'string | number | readonly string[] | undefined'.
  Type 'false' is not assignable to type 'string | number | readonly string[] | undefined'.

29   return <Input type="hidden" value={props.value} />;
                                 ~~~~~

  node_modules/@types/react/index.d.ts:2224:9
    2224         value?: string | ReadonlyArray<string> | number | undefined;
                 ~~~~~
    The expected type comes from property 'value' which is declared here on type 'IntrinsicAttributes & Pick<InputProps, "dir" | "form" | "slot" | "style" | "title" | "pattern" | "id" | "children" | "prefixCls" | "className" | ... 281 more ... | "bordered"> & ... 4 more ... & { ...; }'

If I change the type of value in the interface to value: 'string | number | readonly string[] | undefined'; then there are no errors.

[etr2460]

that sounds good to me

[codecov]

Codecov Report

Merging #17315 (193a7d3) into master (bea8502) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #17315   +/-   ##
=======================================
  Coverage   77.08%   77.09%           
=======================================
  Files        1037     1037           
  Lines       55647    55644    -3     
  Branches     7608     7609    +1     
=======================================
  Hits        42898    42898           
+ Misses      12499    12496    -3     
  Partials      250      250           

Flag	Coverage Δ
javascript	71.26% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../src/explore/components/controls/HiddenControl.tsx	75.00% <100.00%> (ø)
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx	87.71% <0.00%> (+0.58%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bea8502...193a7d3. Read the comment docs.

[etr2460]

/testenv up

[github-actions]

@etr2460 Ephemeral environment spinning up at http://54.191.46.36:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[Damans227]

@etr2460 Ephemeral environment spinning up at http://54.191.46.36:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@etr2460 Looks ok to me.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.