Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: datatable crash when column is empty string [ID-59] #17303

Merged
merged 2 commits into from
Nov 1, 2021
Merged

fix: datatable crash when column is empty string [ID-59] #17303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f720e7
fix: datatable crash when column is empty string
zhaoyongjie Nov 1, 2021
49f84f4
typo
zhaoyongjie Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion superset-frontend/src/explore/components/DataTableControl/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ export const useTableColumns = (
key =>
({
accessor: row => row[key],
Header: key,
// When the key is empty, have to give a string of length greater than 0
Header: key || ' ',
Cell: ({ value }) => {
if (value === true) {
return BOOL_TRUE_DISPLAY;
Expand Down