Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: datatable crash when column is empty string [ID-59] #17303

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Nov 1, 2021

SUMMARY

If a column contains an empty string(not a null value), then use the new time-series chart and open data pane will crash full page.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after

datapane-after.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor nit

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #17303 (49f84f4) into master (6a63a21) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17303   +/-   ##
=======================================
  Coverage   77.08%   77.09%           
=======================================
  Files        1037     1037           
  Lines       55646    55647    +1     
  Branches     7607     7608    +1     
=======================================
+ Hits        42897    42899    +2     
+ Misses      12499    12498    -1     
  Partials      250      250           
Flag Coverage Δ
javascript 71.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/explore/components/DataTableControl/index.tsx 98.21% <100.00%> (+0.03%) ⬆️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 87.71% <0.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a63a21...49f84f4. Read the comment docs.

@zhaoyongjie zhaoyongjie merged commit 1f2a7a4 into apache:master Nov 1, 2021
@zhaoyongjie zhaoyongjie changed the title fix: datatable crash when column is empty string fix: datatable crash when column is empty string [ID-59] Nov 1, 2021
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
* fix: datatable crash when column is empty string

* typo
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants