Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other(revert): "fix: the calculated columns explicit type convert into date" #16950

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Oct 4, 2021

This PR reverts #14813 as there should be no need for type inferencing—which could be incorrect—given that the type of the calculated column should be set in the same modal—exposed if one scrolls.

Note the widget also allows for user entered types, i.e, they're not restricted to only the pre-defined four options.

Screen Shot 2021-10-03 at 7 38 42 PM

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #16950 (e7460fd) into master (792efef) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

❗ Current head e7460fd differs from pull request most recent head d47b34c. Consider uploading reports for the commit d47b34c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16950      +/-   ##
==========================================
- Coverage   76.96%   76.74%   -0.22%     
==========================================
  Files        1038     1038              
  Lines       55612    55611       -1     
  Branches     7590     7590              
==========================================
- Hits        42800    42678     -122     
- Misses      12562    12683     +121     
  Partials      250      250              
Flag Coverage Δ
hive ?
mysql 81.93% <100.00%> (-0.01%) ⬇️
postgres 81.94% <100.00%> (-0.01%) ⬇️
presto ?
python 82.03% <100.00%> (-0.42%) ⬇️
sqlite 81.62% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/connectors/sqla/models.py 85.83% <100.00%> (-1.66%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 69.76% <0.00%> (-17.06%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-6.91%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️
superset/db_engine_specs/base.py 88.20% <0.00%> (-0.39%) ⬇️
superset/utils/core.py 90.02% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 792efef...d47b34c. Read the comment docs.

@john-bodley john-bodley changed the title Revert "fix: the calculated columns explicit type convert into date" other(revert): "fix: the calculated columns explicit type convert into date" Oct 4, 2021
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as fully fixing this is far outside the scope of this (or the reverted) PR

@john-bodley john-bodley merged commit b7e7ef2 into master Oct 27, 2021
@john-bodley john-bodley deleted the revert-14813-explicit_cast branch October 27, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants