-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: the calculated columns explicit type convert into date #14813
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14813 +/- ##
==========================================
- Coverage 77.63% 77.39% -0.24%
==========================================
Files 962 962
Lines 49156 49157 +1
Branches 6183 6183
==========================================
- Hits 38161 38047 -114
- Misses 10792 10907 +115
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a workaround, I think this is a good default for now. However, in the long term it would be great if we could make it possible to sync the calculated column types, similar to how it's possible to sync the regular columns. This shouldn't be difficult to do - just trigger a query with a LIMIT of 1 and pick up the datatypes that come back from the database. However, let's leave that for a follow-up task.
SUMMARY
datetime column(grain columns) get default column type when this column lack of column type.
This situation occurs in the calculated columns.
related issue: #13702
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
make a
calculated columns
and selectedis temporal
checkboxmake
calculated columns
astime columns
and do query.TESTING INSTRUCTIONS
ADDITIONAL INFORMATION