fix: RBAC hide right menu #16902
Merged
fix: RBAC hide right menu #16902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16902 +/- ##
==========================================
- Coverage 77.03% 76.75% -0.28%
==========================================
Files 1021 1022 +1
Lines 54846 54896 +50
Branches 7481 7484 +3
==========================================
- Hits 42248 42133 -115
- Misses 12351 12515 +164
- Partials 247 248 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…nto hugh/rbac-rm-3
hughhhh
force-pushed
the
hugh/rbac-rm-3
branch
from
1a61251
to
7482701
Compare
betodealmeida
requested changes
Sep 30, 2021
| {navbarRight.user_info_url && ( | ||
| <Menu.Item key="info"> | ||
| <a href={navbarRight.user_info_url}>{t('Info')}</a> | ||
| </Menu.Item> | ||
| )} |
There was a problem hiding this comment.
Are you intentionally removing the build number? If so, can you describe why on the PR summary?
There was a problem hiding this comment.
it was a bad rebase on my part just added it back and fixed the test. The build number is here (https://github.com/apache/superset/pull/16902/files#diff-66167b483c9360910449d7ed1078df9d2b3b2500ea69295657e3692e462c9095R192) now
hughhhh
force-pushed
the
hugh/rbac-rm-3
branch
from
fcbffdb
to
13e7915
Compare
hughhhh
force-pushed
the
hugh/rbac-rm-3
branch
from
13e7915
to
1e20585
Compare
betodealmeida
approved these changes
Sep 30, 2021
eschutho
added a commit
to preset-io/superset
that referenced
this pull request
Oct 4, 2021
This reverts commit 87baac7.
eschutho
added a commit
that referenced
this pull request
Oct 5, 2021
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Oct 5, 2021
* Revert "fix: RBAC hide right menu (apache#16902)" This reverts commit 87baac7. * fix failing test (cherry picked from commit 5866d5e)
9 tasks
eschutho
added a commit
to preset-io/superset
that referenced
this pull request
Oct 27, 2021
* Revert "fix: RBAC hide right menu (apache#16902)" This reverts commit 87baac7. * fix failing test (cherry picked from commit 5866d5e)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* add provider to right menu * add roles code * bad pull
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* Revert "fix: RBAC hide right menu (apache#16902)" This reverts commit 87baac7. * fix failing test
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* add provider to right menu * add roles code * bad pull
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* Revert "fix: RBAC hide right menu (apache#16902)" This reverts commit 87baac7. * fix failing test
mistercrunch
added
the
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Hide create button for users that do not have the proper permissions to goto sqllab, create charts, and create dashboards.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION