feat: Hide nav create with RBAC

[hughhhh]

SUMMARY

Remerging #16902 since webpack issue have been resolved

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #17157 (9f30ebb) into master (2062775) will increase coverage by 0.14%.
The diff coverage is 85.10%.

@@            Coverage Diff             @@
##           master   #17157      +/-   ##
==========================================
+ Coverage   76.83%   76.98%   +0.14%     
==========================================
  Files        1038     1042       +4     
  Lines       55557    56277     +720     
  Branches     7567     7794     +227     
==========================================
+ Hits        42687    43323     +636     
- Misses      12620    12701      +81     
- Partials      250      253       +3     

Flag	Coverage Δ
hive	81.45% <ø> (ø)
javascript	71.23% <85.10%> (+0.30%)	⬆️
mysql	81.91% <ø> (ø)
postgres	81.92% <ø> (ø)
presto	81.78% <ø> (?)
python	82.41% <ø> (+0.14%)	⬆️
sqlite	81.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/views/menu.tsx	0.00% <0.00%> (ø)
...uperset-frontend/src/components/Menu/MenuRight.tsx	92.30% <88.88%> (+1.07%)	⬆️
...nativeFilters/FiltersConfigModal/Footer/Footer.tsx	93.75% <0.00%> (-6.25%)	⬇️
.../src/explore/components/DataTableControl/index.tsx	97.53% <0.00%> (-0.47%)	⬇️
...end/src/components/Datasource/DatasourceEditor.jsx	72.10% <0.00%> (ø)
...rc/components/Datasource/ChangeDatasourceModal.tsx	86.36% <0.00%> (ø)
...erset-frontend/src/components/Datasource/index.tsx	100.00% <0.00%> (ø)
...tend/src/components/Datasource/DatasourceModal.tsx	75.38% <0.00%> (ø)
superset/models/core.py	90.00% <0.00%> (+0.73%)	⬆️
...et-frontend/src/components/TableView/TableView.tsx	95.89% <0.00%> (+1.36%)	⬆️
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2062775...9f30ebb. Read the comment docs.

[geido]

/testenv up

[github-actions]

@geido Ephemeral environment spinning up at http://52.41.104.137:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[rosemarie-chiu]

@hughhhh Login as user with perm for sql lab only ✅ PASSED

Login as user with perm for chart edit and read only for dashboard ❓I SEE DASHBOARD not chart ?

Did I test it wrong?

[rosemarie-chiu]

I selected all chart permissions only and still only see dashboard in global add

[eschutho]

@hughhhh this looks good. Can you check that running a query works for you? I wasn't seeing any results in the bottom section for a query or the preview, although the api was returning a response.

[hughhhh]

@rosemarie-chiu so the mapping is based only on writing for the 3 resources

https://github.com/apache/superset/pull/17157/files#diff-66167b483c9360910449d7ed1078df9d2b3b2500ea69295657e3692e462c9095R35-R50

So if the user has the following role it will appear in the create:
can_write Dashboard -> show dashboard
can_write Chart -> show chart
can_sqllab Superset -> show sqllab

also found a small bug and pushed it up so tested it out 1 more time when you get the chance

[hughhhh]

@hughhhh this looks good. Can you check that running a query works for you? I wasn't seeing any results in the bottom section for a query or the preview, although the api was returning a response.

It was working for me in the ephermeral env

Screen.Recording.2021-10-21.at.3.52.09.PM.mov

[hughhhh]

/testenv up

[github-actions]

@hughhhh Ephemeral environment spinning up at http://34.221.76.192:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[rosemarie-chiu]

tested and verified!

[rosemarie-chiu]

LGTM! QA sign off

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.