Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update isort from 4.3 to 5.8.0 #14359

Closed
wants to merge 1 commit into from

Conversation

bungoume
Copy link
Contributor

SUMMARY

Update pre-commit isort to 5.8.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue: Pe-commit hooks using deprecated code #13025
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #14359 (8925db0) into master (9a22fb0) will decrease coverage by 0.14%.
The diff coverage is 75.00%.

❗ Current head 8925db0 differs from pull request most recent head 8e162af. Consider uploading reports for the commit 8e162af to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14359      +/-   ##
==========================================
- Coverage   76.99%   76.85%   -0.15%     
==========================================
  Files         957      957              
  Lines       48126    48126              
  Branches     6047     6047              
==========================================
- Hits        37054    36986      -68     
- Misses      10873    10941      +68     
  Partials      199      199              
Flag Coverage Δ
hive ?
mysql 81.05% <75.00%> (ø)
postgres 81.08% <75.00%> (ø)
presto 80.78% <75.00%> (ø)
python 81.35% <75.00%> (-0.27%) ⬇️
sqlite 80.69% <75.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/cli.py 51.47% <0.00%> (ø)
superset/security/manager.py 91.50% <66.66%> (ø)
superset/app.py 81.37% <100.00%> (ø)
superset/utils/core.py 88.65% <100.00%> (-0.13%) ⬇️
superset/viz.py 55.49% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 70.32% <0.00%> (-17.08%) ⬇️
superset/connectors/sqla/models.py 89.83% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a22fb0...8e162af. Read the comment docs.

@villebro
Copy link
Member

Closing this as isort was bumped to 5.9.3 in #17215 (sorry for not having gotten to this PR in time 🙁 )

@villebro villebro closed this Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pe-commit hooks using deprecated code
2 participants