Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pe-commit hooks using deprecated code #13025

Closed
3 tasks done
TColl opened this issue Feb 9, 2021 · 0 comments
Closed
3 tasks done

Pe-commit hooks using deprecated code #13025

TColl opened this issue Feb 9, 2021 · 0 comments
Labels
question & help wanted Use Github discussions instead

Comments

@TColl
Copy link
Contributor

TColl commented Feb 9, 2021

Since isort v5.0, seed-isort is no longer needed and the source code has been archived.

By bumping the pre-commit hooks to newer versions we can remove the seed-isort hook entirely and stay with code that is actively supported.

Expected results

Pre-commit hooks should be bumped to newer versions to avoid relying on unmaintained code.

Actual results

Pre-commit still using seed-isort and isort v4.3.2.1

Screenshots

NA

How to reproduce the bug

N/A

Environment

(please complete the following information):

  • superset version: v1.0
  • python version: 3.8.5
  • node.js version: 8.15.1

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

N/A

@TColl TColl added the #bug Bug report label Feb 9, 2021
@junlincc junlincc added question & help wanted Use Github discussions instead and removed #bug Bug report labels Mar 31, 2021
@apache apache locked and limited conversation to collaborators Feb 2, 2022
@geido geido converted this issue into discussion #18270 Feb 2, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
question & help wanted Use Github discussions instead
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants