-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Superset edit filter popover disappearing on hover #11394
Comments
Issue-Label Bot is automatically applying the label Links: app homepage, dashboard and code for this bot. |
Related to #11388 |
sure, I'll take a look. Do you want to assign this to me? |
let me know how long it's gonna take you. Kamil and Kasia can help 🙏 |
I have a quick fix, although I think the use of state vs props in the component could use some improvements. If you think it's worth pushing out a fix with the existing code, I can put up a PR now and maybe Kamil and Kasia can help with the longer-term improvements. |
* fix: Custom SQL in FilterPopover * Also fix apache#11394 * linting * fix tests
The filter UI is more sensitive than before, leading to “catch me if you can” type of experience. When adding a filter to a chart (so in Explore view, you click on or trying to edit it, the popover containing filter settings disappears when moving the cursor from the filter to it (check out attached video). This doesn't happen all the time, but when it does, it's very frustrating. Sometimes, the popover displays, but is closed (disappears) before user clicks "save" or "cancel".
Browser: Chrome
Steps to Reproduce:
Result: Popover disappears.
Expected Result: Popover stays in place so I can edit the filter. Unfortunately not able to repro 100%. Happens sometimes... so planing to keep this bug open and keep checking if users encounter it again.
Popover should only close when user clicks on save or cancel, not when user moves mouse around. This piece of the issue is reproduceable more frequently.
Screenshots
Step one: Click on a metric, filter box displays
Step two: Move mouse into the filter box - it disappears
Environment
(please complete the following information):
Checklist
Make sure these boxes are checked before submitting your issue - thank you!
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: