Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superset edit filter popover disappearing on hover #11394

Closed
2 of 3 tasks
zuzana-vej opened this issue Oct 22, 2020 · 8 comments
Closed
2 of 3 tasks

Superset edit filter popover disappearing on hover #11394

zuzana-vej opened this issue Oct 22, 2020 · 8 comments
Assignees
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@zuzana-vej
Copy link
Contributor

zuzana-vej commented Oct 22, 2020

The filter UI is more sensitive than before, leading to “catch me if you can” type of experience. When adding a filter to a chart (so in Explore view, you click on or trying to edit it, the popover containing filter settings disappears when moving the cursor from the filter to it (check out attached video). This doesn't happen all the time, but when it does, it's very frustrating. Sometimes, the popover displays, but is closed (disappears) before user clicks "save" or "cancel".

Browser: Chrome

Steps to Reproduce:

  1. Create or open superset chart.
  2. Click filter.
  3. Hover to edit filter popover.

Result: Popover disappears.

Expected Result: Popover stays in place so I can edit the filter. Unfortunately not able to repro 100%. Happens sometimes... so planing to keep this bug open and keep checking if users encounter it again.

Popover should only close when user clicks on save or cancel, not when user moves mouse around. This piece of the issue is reproduceable more frequently.

Screenshots

Step one: Click on a metric, filter box displays
Screen Shot 2020-10-22 at 9 02 14 AM

Step two: Move mouse into the filter box - it disappears
Screen Shot 2020-10-22 at 9 02 20 AM

Environment

(please complete the following information):

  • superset version: master

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@zuzana-vej zuzana-vej added the !deprecated-label:bug Deprecated label - Use #bug instead label Oct 22, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.93. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@zuzana-vej
Copy link
Contributor Author

Related to #11388

@junlincc
Copy link
Member

junlincc commented Oct 22, 2020

💔💔💔!

@eschutho could you please take a look at #11394, #11388 and #11379, i think they are all related. 🙏

@junlincc junlincc self-assigned this Oct 22, 2020
@eschutho
Copy link
Member

sure, I'll take a look. Do you want to assign this to me?

@junlincc
Copy link
Member

sure, I'll take a look. Do you want to assign this to me?

let me know how long it's gonna take you. Kamil and Kasia can help 🙏

@eschutho
Copy link
Member

eschutho commented Oct 23, 2020

I have a quick fix, although I think the use of state vs props in the component could use some improvements. If you think it's worth pushing out a fix with the existing code, I can put up a PR now and maybe Kamil and Kasia can help with the longer-term improvements.

@junlincc
Copy link
Member

#11163 @kgabryje Kamil~

@zuzana-vej
Copy link
Contributor Author

Here is another video recording when it disappears after user starts typing, if they move their mouse outside the popover area.

popover-issue-2

mistercrunch added a commit to preset-io/superset that referenced this issue Oct 23, 2020
@mistercrunch mistercrunch self-assigned this Oct 23, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this issue Nov 20, 2020
* fix: Custom SQL in FilterPopover

* Also fix apache#11394

* linting

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

No branches or pull requests

4 participants