Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple issues with FilterPopover #11412

Merged
merged 4 commits into from
Oct 27, 2020

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Oct 23, 2020

SUMMARY

closes #11411, #11394

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2020-10-23 at 9 00 06 AM

TEST PLAN

manually tested, tested both HAVING and WHERE, going back and forth

@codecov-io
Copy link

codecov-io commented Oct 23, 2020

Codecov Report

Merging #11412 into master will increase coverage by 0.16%.
The diff coverage is 55.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11412      +/-   ##
==========================================
+ Coverage   66.48%   66.65%   +0.16%     
==========================================
  Files         859      861       +2     
  Lines       40853    40920      +67     
  Branches     3686     3693       +7     
==========================================
+ Hits        27162    27276     +114     
+ Misses      13590    13546      -44     
+ Partials      101       98       -3     
Flag Coverage Δ
#cypress 57.04% <73.64%> (+0.73%) ⬆️
#javascript 62.90% <41.22%> (-0.06%) ⬇️
#python 61.96% <70.73%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/SqlLab/components/ExploreResultsButton.jsx 73.75% <0.00%> (ø)
...et-frontend/src/SqlLab/components/LimitControl.tsx 89.36% <ø> (ø)
...rset-frontend/src/SqlLab/components/QueryTable.jsx 66.66% <ø> (ø)
...erset-frontend/src/SqlLab/components/SaveQuery.tsx 88.09% <ø> (ø)
...tend/src/SqlLab/components/ScheduleQueryButton.jsx 8.62% <ø> (ø)
...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx 93.54% <ø> (ø)
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 53.33% <ø> (ø)
superset-frontend/src/chart/Chart.jsx 58.18% <ø> (ø)
...-frontend/src/common/components/common.stories.tsx 0.00% <0.00%> (ø)
...perset-frontend/src/components/AlteredSliceTag.jsx 84.26% <ø> (ø)
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f69212...e4eb611. Read the comment docs.

@mistercrunch mistercrunch changed the title fix: Custom SQL in FilterPopover fix: multiple issues with FilterPopover Oct 23, 2020
@@ -178,21 +179,22 @@ export default class AdhocFilterEditPopover extends React.Component {
</Tab>
</Tabs>
<div>
<Button buttonSize="small" onClick={this.props.onClose} cta>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n, flip button (Save to the right and primary)

@@ -87,7 +87,7 @@ describe('Annotations', () => {
.within(() => {
cy.get('input').type('y=1400000');
});
cy.get('button').contains('OK').click();
cy.get('button').contains('OK').click({ force: true });
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2020-10-23 at 6 34 01 PM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bycatch, random cypress/CI failure

@kgabryje kgabryje mentioned this pull request Oct 26, 2020
6 tasks
@mistercrunch
Copy link
Member Author

@kgabryje do you want to take it from here? Sounds like you know about some edges I did not encounter.

@kgabryje
Copy link
Member

kgabryje commented Oct 26, 2020

@mistercrunch Beside the changes in AdhocFilterOption, the rest looks good to me. After we merge this PR and mine, there will be 1 issue related to controls left and I can take it.

@mistercrunch mistercrunch force-pushed the fix_having branch 2 times, most recently from 206fb75 to dddcab0 Compare October 26, 2020 19:42
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v0.38 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charts: Filters Custom SQL Where/Having dropdown never selecting
5 participants