-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: multiple issues with FilterPopover #11412
Conversation
87a9104
to
4f5cd4f
Compare
Codecov Report
@@ Coverage Diff @@
## master #11412 +/- ##
==========================================
+ Coverage 66.48% 66.65% +0.16%
==========================================
Files 859 861 +2
Lines 40853 40920 +67
Branches 3686 3693 +7
==========================================
+ Hits 27162 27276 +114
+ Misses 13590 13546 -44
+ Partials 101 98 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -178,21 +179,22 @@ export default class AdhocFilterEditPopover extends React.Component { | |||
</Tab> | |||
</Tabs> | |||
<div> | |||
<Button buttonSize="small" onClick={this.props.onClose} cta> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i18n, flip button (Save
to the right and primary)
106ede2
to
42e11a5
Compare
@@ -87,7 +87,7 @@ describe('Annotations', () => { | |||
.within(() => { | |||
cy.get('input').type('y=1400000'); | |||
}); | |||
cy.get('button').contains('OK').click(); | |||
cy.get('button').contains('OK').click({ force: true }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bycatch, random cypress/CI failure
@kgabryje do you want to take it from here? Sounds like you know about some edges I did not encounter. |
@mistercrunch Beside the changes in |
206fb75
to
dddcab0
Compare
dddcab0
to
e4eb611
Compare
* fix: Custom SQL in FilterPopover * Also fix apache#11394 * linting * fix tests
SUMMARY
closes #11411, #11394
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
manually tested, tested both HAVING and WHERE, going back and forth