Skip to content

[SPARK-5722] [SQL] [PySpark] infer int as LongType #4666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-5722] [SQL] [PySpark] infer int as LongType #4666

wants to merge 1 commit into from

Conversation

davies
Copy link
Contributor

@davies davies commented Feb 18, 2015

The int is 64-bit on 64-bit machine (very common now), we should infer it as LongType for it in Spark SQL.

Also, LongType in SQL will come back as int.

@davies davies mentioned this pull request Feb 18, 2015
Closed
@SparkQA
Copy link

SparkQA commented Feb 18, 2015

Test build #613 has started for PR 4666 at commit 6bc6cc4.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 18, 2015

Test build #27664 has started for PR 4666 at commit 6bc6cc4.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 18, 2015

Test build #27664 has finished for PR 4666 at commit 6bc6cc4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27664/
Test PASSed.

@dondrake
Copy link

@davies THANKS!

@SparkQA
Copy link

SparkQA commented Feb 18, 2015

Test build #613 has finished for PR 4666 at commit 6bc6cc4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Feb 18, 2015
@marmbrus
[SPARK-5722] [SQL] [PySpark] infer int as LongType
470cba8 
The `int` is 64-bit on 64-bit machine (very common now), we should infer it as LongType for it in Spark SQL.

Also, LongType in SQL will come back as `int`.

Author: Davies Liu <davies@databricks.com>

Closes #4666 from davies/long and squashes the following commits:

6bc6cc4 [Davies Liu] infer int as LongType

(cherry picked from commit aa8f10e)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@asfgit asfgit closed this in aa8f10e Feb 18, 2015
@marmbrus
Copy link
Contributor

Thanks! Merged to master and 1.3. @dondrake this doesn't apply cleanly to branch-1.2. @davies, how hard would this be to back port?

@dondrake
Copy link

Great news on 1.3.

Please see #4521 for my PR for branch-1.2. It's not exactly the same as what @davies did for 1.3.

@davies
Copy link
Contributor Author

davies commented Feb 18, 2015

@marmbrus I will create another patch for 1.2

@dondrake dondrake mentioned this pull request Feb 18, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davies @SparkQA @AmplabJenkins @dondrake @marmbrus