Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR][PYTHON][DOCS] Remove duplicated versionchanged per versionadded #42602

Closed
wants to merge 2 commits into from

Conversation

HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Aug 22, 2023

What changes were proposed in this pull request?

This PR addresses all the cases of duplicated versionchanged directives with versionadded directives, see also #42597.

Also, this PR mentions that all functions support Spark Connect from Apache Spark 3.5.0.

Why are the changes needed?

To remove duplicated information in docstring.

Does this PR introduce any user-facing change?

Yes, it removes duplicated information in PySpark API Reference page.

How was this patch tested?

CI in this PR should validate them.

Was this patch authored or co-authored using generative AI tooling?

No.

@HyukjinKwon
Copy link
Member Author

cc @LuciferYang @yaooqinn @zhengruifeng FYI

@@ -39,11 +39,7 @@ def __init__(self, jconf: JavaObject) -> None:

@since(2.0)
def set(self, key: str, value: Union[str, int, bool]) -> None:
"""Sets the given Spark runtime configuration property.

.. versionchanged:: 3.4.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. versionchanged:: 3.4.0 is mentioned at the class level above.

@HyukjinKwon
Copy link
Member Author

Merged to master and branch-3.5.

HyukjinKwon added a commit that referenced this pull request Aug 22, 2023
### What changes were proposed in this pull request?

This PR addresses all the cases of duplicated `versionchanged` directives with `versionadded` directives, see also #42597.

Also, this PR mentions that all functions support Spark Connect from Apache Spark 3.5.0.

### Why are the changes needed?

To remove duplicated information in docstring.

### Does this PR introduce _any_ user-facing change?

Yes, it removes duplicated information in PySpark API Reference page.

### How was this patch tested?

CI in this PR should validate them.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes #42602 from HyukjinKwon/minor-versionchanges.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 65b8ca2)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
valentinp17 pushed a commit to valentinp17/spark that referenced this pull request Aug 24, 2023
### What changes were proposed in this pull request?

This PR addresses all the cases of duplicated `versionchanged` directives with `versionadded` directives, see also apache#42597.

Also, this PR mentions that all functions support Spark Connect from Apache Spark 3.5.0.

### Why are the changes needed?

To remove duplicated information in docstring.

### Does this PR introduce _any_ user-facing change?

Yes, it removes duplicated information in PySpark API Reference page.

### How was this patch tested?

CI in this PR should validate them.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#42602 from HyukjinKwon/minor-versionchanges.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
@HyukjinKwon HyukjinKwon deleted the minor-versionchanges branch January 15, 2024 00:51
ragnarok56 pushed a commit to ragnarok56/spark that referenced this pull request Mar 2, 2024
### What changes were proposed in this pull request?

This PR addresses all the cases of duplicated `versionchanged` directives with `versionadded` directives, see also apache#42597.

Also, this PR mentions that all functions support Spark Connect from Apache Spark 3.5.0.

### Why are the changes needed?

To remove duplicated information in docstring.

### Does this PR introduce _any_ user-facing change?

Yes, it removes duplicated information in PySpark API Reference page.

### How was this patch tested?

CI in this PR should validate them.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#42602 from HyukjinKwon/minor-versionchanges.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants