[SPARK-44904][PYTHON][DOCS] Correct the versionadded of sql.functions.approx_percentile to 3.5.0
#42597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
sql.functions.approx_percentile to 3.5.0versionchanged of sql.functions.approx_percentile to 3.5.0
LuciferYang
changed the title
versionchanged of sql.functions.approx_percentile to 3.5.0versionadded of sql.functions.approx_percentile to 3.5.0
zhengruifeng
approved these changes
Aug 22, 2023
HyukjinKwon
reviewed
Aug 22, 2023
HyukjinKwon
approved these changes
Aug 22, 2023
|
Merged to master and branch-3.5. |
HyukjinKwon
added a commit
that referenced
this pull request
Aug 22, 2023
…ons.approx_percentile` to 3.5.0 ### What changes were proposed in this pull request? `sql.functions.approx_percentile` was introduced in SPARK-43941 (#41588). This is a pr for the Spark 3.5.0 and it does not belong to Spark 3.4.0. Therefore, this pr corrects the `versionadded` of `sql.functions.approx_percentile` to 3.5.0 and removed `versionchanged`. ### Why are the changes needed? Correct the `versionadded` of `sql.functions.approx_percentile`. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #42597 from LuciferYang/SPARK-44904. Lead-authored-by: yangjie01 <yangjie01@baidu.com> Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 534f9ea) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
|
Thanks @HyukjinKwon @zhengruifeng |
HyukjinKwon
added a commit
that referenced
this pull request
Aug 22, 2023
### What changes were proposed in this pull request? This PR addresses all the cases of duplicated `versionchanged` directives with `versionadded` directives, see also #42597. Also, this PR mentions that all functions support Spark Connect from Apache Spark 3.5.0. ### Why are the changes needed? To remove duplicated information in docstring. ### Does this PR introduce _any_ user-facing change? Yes, it removes duplicated information in PySpark API Reference page. ### How was this patch tested? CI in this PR should validate them. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #42602 from HyukjinKwon/minor-versionchanges. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
added a commit
that referenced
this pull request
Aug 22, 2023
### What changes were proposed in this pull request? This PR addresses all the cases of duplicated `versionchanged` directives with `versionadded` directives, see also #42597. Also, this PR mentions that all functions support Spark Connect from Apache Spark 3.5.0. ### Why are the changes needed? To remove duplicated information in docstring. ### Does this PR introduce _any_ user-facing change? Yes, it removes duplicated information in PySpark API Reference page. ### How was this patch tested? CI in this PR should validate them. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #42602 from HyukjinKwon/minor-versionchanges. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 65b8ca2) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
valentinp17
pushed a commit
to valentinp17/spark
that referenced
this pull request
Aug 24, 2023
…ons.approx_percentile` to 3.5.0 ### What changes were proposed in this pull request? `sql.functions.approx_percentile` was introduced in SPARK-43941 (apache#41588). This is a pr for the Spark 3.5.0 and it does not belong to Spark 3.4.0. Therefore, this pr corrects the `versionadded` of `sql.functions.approx_percentile` to 3.5.0 and removed `versionchanged`. ### Why are the changes needed? Correct the `versionadded` of `sql.functions.approx_percentile`. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#42597 from LuciferYang/SPARK-44904. Lead-authored-by: yangjie01 <yangjie01@baidu.com> Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
valentinp17
pushed a commit
to valentinp17/spark
that referenced
this pull request
Aug 24, 2023
### What changes were proposed in this pull request? This PR addresses all the cases of duplicated `versionchanged` directives with `versionadded` directives, see also apache#42597. Also, this PR mentions that all functions support Spark Connect from Apache Spark 3.5.0. ### Why are the changes needed? To remove duplicated information in docstring. ### Does this PR introduce _any_ user-facing change? Yes, it removes duplicated information in PySpark API Reference page. ### How was this patch tested? CI in this PR should validate them. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#42602 from HyukjinKwon/minor-versionchanges. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
…ons.approx_percentile` to 3.5.0 ### What changes were proposed in this pull request? `sql.functions.approx_percentile` was introduced in SPARK-43941 (apache#41588). This is a pr for the Spark 3.5.0 and it does not belong to Spark 3.4.0. Therefore, this pr corrects the `versionadded` of `sql.functions.approx_percentile` to 3.5.0 and removed `versionchanged`. ### Why are the changes needed? Correct the `versionadded` of `sql.functions.approx_percentile`. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#42597 from LuciferYang/SPARK-44904. Lead-authored-by: yangjie01 <yangjie01@baidu.com> Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
### What changes were proposed in this pull request? This PR addresses all the cases of duplicated `versionchanged` directives with `versionadded` directives, see also apache#42597. Also, this PR mentions that all functions support Spark Connect from Apache Spark 3.5.0. ### Why are the changes needed? To remove duplicated information in docstring. ### Does this PR introduce _any_ user-facing change? Yes, it removes duplicated information in PySpark API Reference page. ### How was this patch tested? CI in this PR should validate them. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#42602 from HyukjinKwon/minor-versionchanges. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
sql.functions.approx_percentilewas introduced in SPARK-43941 (#41588). This is a pr for the Spark 3.5.0 and it does not belong to Spark 3.4.0. Therefore, this pr corrects theversionaddedofsql.functions.approx_percentileto 3.5.0 and removedversionchanged.Why are the changes needed?
Correct the
versionaddedofsql.functions.approx_percentile.Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No