[SPARK-42305][SQL] Integrate _LEGACY_ERROR_TEMP_1229 into DECIMAL_PRECISION_EXCEEDS_MAX_PRECISION
#39875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I think we can reuse |
MaxGekk
requested changes
Feb 4, 2023
| val e = intercept[SparkArithmeticException](defaultParser.parseExpression("1.20E-38BD")) | ||
| checkError( | ||
| exception = parseException("1.20E-38BD"), | ||
| errorClass = "_LEGACY_ERROR_TEMP_0061", |
Member
There was a problem hiding this comment.
Sorry, I didn't get. The PR title and description are telling only about one error class LEGACY_ERROR_TEMP_1229 but your PR affects another one. Could you elaborate this and revert unrelated changes, or make PR's title/description consistent with PR's changes.
Contributor
Author
There was a problem hiding this comment.
Yeah, you're right.
I should have fixed sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala rather than tests.
Just reverted unrelated changes and fix them in proper way.
Thanks!
Member
|
+1, LGTM. Merging to master/3.4. |
MaxGekk
pushed a commit
that referenced
this pull request
Feb 8, 2023
…PRECISION_EXCEEDS_MAX_PRECISION`
### What changes were proposed in this pull request?
This PR proposes to integrate `_LEGACY_ERROR_TEMP_1229` into `DECIMAL_PRECISION_EXCEEDS_MAX_PRECISION`.
**_LEGACY_ERROR_TEMP_1229**
```json
"_LEGACY_ERROR_TEMP_1229" : {
"message" : [
"<decimalType> can only support precision up to <precision>."
]
},
```
**DECIMAL_PRECISION_EXCEEDS_MAX_PRECISION**
```json
"DECIMAL_PRECISION_EXCEEDS_MAX_PRECISION" : {
"message" : [
"Decimal precision <precision> exceeds max precision <maxPrecision>."
],
"sqlState" : "22003"
},
```
### Why are the changes needed?
We should assign proper name to _LEGACY_ERROR_TEMP_*
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
`./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*"`
Closes #39875 from itholic/LEGACY_1229.
Authored-by: itholic <haejoon.lee@databricks.com>
Signed-off-by: Max Gekk <max.gekk@gmail.com>
(cherry picked from commit f8e06c1)
Signed-off-by: Max Gekk <max.gekk@gmail.com>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…PRECISION_EXCEEDS_MAX_PRECISION`
### What changes were proposed in this pull request?
This PR proposes to integrate `_LEGACY_ERROR_TEMP_1229` into `DECIMAL_PRECISION_EXCEEDS_MAX_PRECISION`.
**_LEGACY_ERROR_TEMP_1229**
```json
"_LEGACY_ERROR_TEMP_1229" : {
"message" : [
"<decimalType> can only support precision up to <precision>."
]
},
```
**DECIMAL_PRECISION_EXCEEDS_MAX_PRECISION**
```json
"DECIMAL_PRECISION_EXCEEDS_MAX_PRECISION" : {
"message" : [
"Decimal precision <precision> exceeds max precision <maxPrecision>."
],
"sqlState" : "22003"
},
```
### Why are the changes needed?
We should assign proper name to _LEGACY_ERROR_TEMP_*
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
`./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*"`
Closes apache#39875 from itholic/LEGACY_1229.
Authored-by: itholic <haejoon.lee@databricks.com>
Signed-off-by: Max Gekk <max.gekk@gmail.com>
(cherry picked from commit f8e06c1)
Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to integrate
_LEGACY_ERROR_TEMP_1229intoDECIMAL_PRECISION_EXCEEDS_MAX_PRECISION._LEGACY_ERROR_TEMP_1229
DECIMAL_PRECISION_EXCEEDS_MAX_PRECISION
Why are the changes needed?
We should assign proper name to LEGACY_ERROR_TEMP*
Does this PR introduce any user-facing change?
No
How was this patch tested?
./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*"