Skip to content

Conversation

@Yikun
Copy link
Member

@Yikun Yikun commented Jan 13, 2022

What changes were proposed in this pull request?

Change actions to check-runs in update_build_status.yml.

Why are the changes needed?

#35179 (comment)

Does this PR introduce any user-facing change?

No

How was this patch tested?

@HyukjinKwon
Copy link
Member

Let's just get this in first.

@HyukjinKwon HyukjinKwon marked this pull request as ready for review January 13, 2022 09:28
@HyukjinKwon
Copy link
Member

Merged to master.

@HyukjinKwon
Copy link
Member

Ah, this only checks the status of "Configure Jobs" .. am gonna revert this and original PR for now.

@Yikun
Copy link
Member Author

Yikun commented Jan 13, 2022

Yep, below is the right way for update_build_status:

  1. First get the check_suite id data.check_suite.id:
    https://api.github.com/repos/Yikun/spark/check-runs/4797718278
  2. Then we need a extra api request on check-suites, get the status of check-suites as final status
    https://api.github.com/repos/Yikun/spark/check-suites/4918519335

See also:
https://github.com/apache/spark/pull/35192/files

dchvn pushed a commit to dchvn/spark that referenced this pull request Jan 19, 2022
…_build_status.yml

### What changes were proposed in this pull request?
Change actions to check-runs in update_build_status.yml.

### Why are the changes needed?
apache#35179 (comment)

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?

Closes apache#35189 from Yikun/patch-11.

Authored-by: Yikun Jiang <yikunkero@gmail.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants