[SPARK-37889][SQL] Replace Log4j2 MarkerFilter with RegexFilter #35186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
HyukjinKwon
approved these changes
Jan 13, 2022
viirya
approved these changes
Jan 13, 2022
Member
|
@yaooqinn Can you re-trigger the GA? Looks it was passed, but it still shows some checks haven't completed yet... |
Member
|
oops, sorry I think that's a bug from my Pr (#35179 (comment)). @Yikun is fixing it 🙏 . I think we can just merge - the test seems it passed. |
Member
Author
|
https://github.com/yaooqinn/spark/runs/4798434360 manually checked the test result which shows OK |
Member
|
Merged to master. |
Member
|
Okay, looks good. |
dchvn
pushed a commit
to dchvn/spark
that referenced
this pull request
Jan 19, 2022
### What changes were proposed in this pull request? Log4j2 MarkerFilter can not suppress ``` 10:55:54.597 ERROR org.apache.thrift.server.TThreadPoolServer: Thrift error occurred during processing of message. org.apache.thrift.transport.TTransportException: null at org.apache.thrift.transport.TIOStreamTransport.read(TIOStreamTransport.java:132) ~[libthrift-0.12.0.jar:0.12.0] ``` We shall use RegexFilter instead ### Why are the changes needed? bugfix ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? run `build/sbt -Phive -Phive-thriftserver "hive-thriftserver/testOnly *ThriftServerWithSparkContextInBinarySuite"` locally and checked Closes apache#35186 from yaooqinn/SPARK-37889. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
sumwale
pushed a commit
to TIBCOSoftware/snappy-spark
that referenced
this pull request
Feb 9, 2022
### What changes were proposed in this pull request? Log4j2 MarkerFilter can not suppress ``` 10:55:54.597 ERROR org.apache.thrift.server.TThreadPoolServer: Thrift error occurred during processing of message. org.apache.thrift.transport.TTransportException: null at org.apache.thrift.transport.TIOStreamTransport.read(TIOStreamTransport.java:132) ~[libthrift-0.12.0.jar:0.12.0] ``` We shall use RegexFilter instead ### Why are the changes needed? bugfix ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? run `build/sbt -Phive -Phive-thriftserver "hive-thriftserver/testOnly *ThriftServerWithSparkContextInBinarySuite"` locally and checked Closes apache#35186 from yaooqinn/SPARK-37889. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
### What changes were proposed in this pull request? Log4j2 MarkerFilter can not suppress ``` 10:55:54.597 ERROR org.apache.thrift.server.TThreadPoolServer: Thrift error occurred during processing of message. org.apache.thrift.transport.TTransportException: null at org.apache.thrift.transport.TIOStreamTransport.read(TIOStreamTransport.java:132) ~[libthrift-0.12.0.jar:0.12.0] ``` We shall use RegexFilter instead ### Why are the changes needed? bugfix ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? run `build/sbt -Phive -Phive-thriftserver "hive-thriftserver/testOnly *ThriftServerWithSparkContextInBinarySuite"` locally and checked Closes apache#35186 from yaooqinn/SPARK-37889. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
asiunov
pushed a commit
to ascend-io/spark
that referenced
this pull request
Aug 25, 2022
### What changes were proposed in this pull request? Log4j2 MarkerFilter can not suppress ``` 10:55:54.597 ERROR org.apache.thrift.server.TThreadPoolServer: Thrift error occurred during processing of message. org.apache.thrift.transport.TTransportException: null at org.apache.thrift.transport.TIOStreamTransport.read(TIOStreamTransport.java:132) ~[libthrift-0.12.0.jar:0.12.0] ``` We shall use RegexFilter instead ### Why are the changes needed? bugfix ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? run `build/sbt -Phive -Phive-thriftserver "hive-thriftserver/testOnly *ThriftServerWithSparkContextInBinarySuite"` locally and checked Closes apache#35186 from yaooqinn/SPARK-37889. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 8ed6144)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Log4j2 MarkerFilter can not suppress
We shall use RegexFilter instead
Why are the changes needed?
bugfix
Does this PR introduce any user-facing change?
no
How was this patch tested?
run
build/sbt -Phive -Phive-thriftserver "hive-thriftserver/testOnly *ThriftServerWithSparkContextInBinarySuite"locally and checked