Skip to content

[SPARK-37879][INFRA] Show test report in GitHub Actions builds from PRs #35179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-37879][INFRA] Show test report in GitHub Actions builds from PRs #35179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/notify_test_workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,15 @@ jobs:
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const endpoint = 'GET /repos/:owner/:repo/actions/workflows/:id/runs?&branch=:branch'
const endpoint = 'GET /repos/:owner/:repo/commits/:ref/check-runs'

// TODO: Should use pull_request.user and pull_request.user.repos_url?
// If a different person creates a commit to another forked repo,
// it wouldn't be able to detect.
const params = {
owner: context.payload.pull_request.head.repo.owner.login,
repo: context.payload.pull_request.head.repo.name,
id: 'build_and_test.yml',
branch: context.payload.pull_request.head.ref,
ref: context.payload.pull_request.head.ref,
}

console.log('Ref: ' + context.payload.pull_request.head.ref)
Expand All @@ -68,7 +67,7 @@ jobs:
const head_sha = context.payload.pull_request.head.sha
let status = 'queued'

if (!runs || runs.data.workflow_runs.length === 0) {
if (!runs || runs.data.check_runs.filter(r => r.name === "Configure jobs").length === 0) {
status = 'completed'
const conclusion = 'action_required'

Expand Down Expand Up @@ -100,15 +99,15 @@ jobs:
}
})
} else {
const runID = runs.data.workflow_runs[0].id
const runID = runs.data.check_runs.filter(r => r.name === "Configure jobs")[0].id

if (runs.data.workflow_runs[0].head_sha != context.payload.pull_request.head.sha) {
if (runs.data.check_runs[0].head_sha != context.payload.pull_request.head.sha) {
throw new Error('There was a new unsynced commit pushed. Please retrigger the workflow.');
}

const runUrl = 'https://github.com/'
+ context.payload.pull_request.head.repo.full_name
+ '/actions/runs/'
+ '/runs/'
+ runID

github.checks.create({
Expand Down