Skip to content

[SPARK-4255] Fix incorrect table striping #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-4255] Fix incorrect table striping #3117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/src/main/resources/org/apache/spark/ui/static/additional-metrics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ $(function() {
var column = "table ." + $(this).attr("name");
$(column).hide();
});
// Stripe table rows after rows have been hidden to ensure correct striping.
stripeTables();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is orthogonal to this PR - but do you know how expensive this function is if there are hundreds of thousands of rows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This striping code is at the frontier of my extremely limited JavaScipt knowledge -- I have no idea how it compares to the default bootstrap striping, which uses CSS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if you just write a small program that creates tens of thousands of tasks... can the stage page load without hanging?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of the additional metrics stuff becomes problematic with thousands of tasks. The striping stuff is significantly worse than the CSS striping (the CSS striping loads quickly, where as the new JavaScript striping can take as long as 30 seconds after the page loads). This is semi-easily fixable by only doing the custom striping for the summary table. But, the page still takes a while to finish loading (you can see it quickly, but it keeps doing JS for a while) because (I think) of the Javascript to hide columns. It's possible this could be fixed by using an ID rather than classname to find the columns to hide, because the ID query selector is much more efficient. LMK how much of an issue you think these are and I can file a JIRA appropriately.


$("input:checkbox").click(function() {
var column = "table ." + $(this).attr("name");
Expand Down
5 changes: 0 additions & 5 deletions core/src/main/resources/org/apache/spark/ui/static/table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,3 @@ function stripeTables() {
});
});
}

/* Stripe all tables after pages finish loading. */
$(function() {
stripeTables();
});