[SPARK-4255] Fix incorrect table striping #3117
Conversation
This commit stripes table rows after hiding some rows, to ensure that rows are correct striped to alternate white and grey even when rows are hidden by default.
|
Test build #22948 has started for PR 3117 at commit
|
| @@ -39,6 +39,8 @@ $(function() { | |||
| var column = "table ." + $(this).attr("name"); | |||
| $(column).hide(); | |||
| }); | |||
| // Stripe table rows after rows have been hidden to ensure correct striping. | |||
| stripeTables(); | |||
There was a problem hiding this comment.
This comment is orthogonal to this PR - but do you know how expensive this function is if there are hundreds of thousands of rows?
There was a problem hiding this comment.
This striping code is at the frontier of my extremely limited JavaScipt knowledge -- I have no idea how it compares to the default bootstrap striping, which uses CSS
There was a problem hiding this comment.
What if you just write a small program that creates tens of thousands of tasks... can the stage page load without hanging?
There was a problem hiding this comment.
A bunch of the additional metrics stuff becomes problematic with thousands of tasks. The striping stuff is significantly worse than the CSS striping (the CSS striping loads quickly, where as the new JavaScript striping can take as long as 30 seconds after the page loads). This is semi-easily fixable by only doing the custom striping for the summary table. But, the page still takes a while to finish loading (you can see it quickly, but it keeps doing JS for a while) because (I think) of the Javascript to hide columns. It's possible this could be fixed by using an ID rather than classname to find the columns to hide, because the ID query selector is much more efficient. LMK how much of an issue you think these are and I can file a JIRA appropriately.
|
Test build #22948 has finished for PR 3117 at commit
|
|
Test PASSed. |
|
LGTM |
This commit stripes table rows after hiding some rows, to ensure that rows are correct striped to alternate white and grey even when rows are hidden by default. Author: Kay Ousterhout <kayousterhout@gmail.com> Closes #3117 from kayousterhout/striping and squashes the following commits: be6e10a [Kay Ousterhout] [SPARK-4255] Fix incorrect table striping (cherry picked from commit 5f27ae1) Signed-off-by: Kay Ousterhout <kayousterhout@gmail.com>
This commit stripes table rows after hiding some rows, to
ensure that rows are correct striped to alternate white
and grey even when rows are hidden by default.