[SPARK-33992][SQL] override transformUpWithNewOutput to add allowInvokingTransformsInAnalyzer #31013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…peratorsUpWithNewOutput
yaooqinn
changed the title
|
cc @cloud-fan @maropu @dongjoon-hyun thanks very much |
maropu
reviewed
Jan 4, 2021
| @@ -451,6 +451,21 @@ trait CharVarcharTestSuite extends QueryTest with SQLTestUtils { | |||
| Seq(Row("char(5)"), Row("varchar(3)"))) | |||
| } | |||
| } | |||
|
|
|||
| test("SPARK-33992: char/varchar resolution in correlated sub query ") { | |||
There was a problem hiding this comment.
branch-3.0 has the same issue? The branch does not have PaddingAndLengthCheckForCharVarchar though.
There was a problem hiding this comment.
nit: remove the unnecessary space in the end: in correlated sub query ") -> in correlated sub query")
maropu
reviewed
Jan 4, 2021
| checkAnswer(sql( | ||
| """ | ||
| |SELECT v FROM t1 | ||
| | WHERE 'a' IN (SELECT v FROM t2 WHERE t1.c = t2.c )""".stripMargin), |
There was a problem hiding this comment.
nit: | WHERE 'a' IN -> |WHERE 'a' IN?
cloud-fan
approved these changes
Jan 4, 2021
|
This looks okay but maybe clean up the PR title and description a little bit? |
maropu
approved these changes
Jan 4, 2021
yaooqinn
changed the title
|
@viirya thanks for reminding me |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
GA passed, merging to master/3.1! |
cloud-fan
pushed a commit
that referenced
this pull request
Jan 5, 2021
…kingTransformsInAnalyzer ### What changes were proposed in this pull request? In #29643, we move the plan rewriting methods to QueryPlan. we need to override transformUpWithNewOutput to add allowInvokingTransformsInAnalyzer because it and resolveOperatorsUpWithNewOutput are called in the analyzer. For example, PaddingAndLengthCheckForCharVarchar could fail query when resolveOperatorsUpWithNewOutput with ```logtalk [info] - char/varchar resolution in sub query *** FAILED *** (367 milliseconds) [info] java.lang.RuntimeException: This method should not be called in the analyzer [info] at org.apache.spark.sql.catalyst.plans.logical.AnalysisHelper.assertNotAnalysisRule(AnalysisHelper.scala:150) [info] at org.apache.spark.sql.catalyst.plans.logical.AnalysisHelper.assertNotAnalysisRule$(AnalysisHelper.scala:146) [info] at org.apache.spark.sql.catalyst.plans.logical.LogicalPlan.assertNotAnalysisRule(LogicalPlan.scala:29) [info] at org.apache.spark.sql.catalyst.plans.logical.AnalysisHelper.transformDown(AnalysisHelper.scala:161) [info] at org.apache.spark.sql.catalyst.plans.logical.AnalysisHelper.transformDown$(AnalysisHelper.scala:160) [info] at org.apache.spark.sql.catalyst.plans.logical.LogicalPlan.transformDown(LogicalPlan.scala:29) [info] at org.apache.spark.sql.catalyst.plans.logical.LogicalPlan.transformDown(LogicalPlan.scala:29) [info] at org.apache.spark.sql.catalyst.plans.QueryPlan.org$apache$spark$sql$catalyst$plans$QueryPlan$$updateOuterReferencesInSubquery(QueryPlan.scala:267) ``` ### Why are the changes needed? trivial bugfix ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? new tests Closes #31013 from yaooqinn/SPARK-33992. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit f0ffe0c) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
Test build #133609 has finished for PR 31013 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In #29643, we move the plan rewriting methods to QueryPlan. we need to override transformUpWithNewOutput to add allowInvokingTransformsInAnalyzer
because it and resolveOperatorsUpWithNewOutput are called in the analyzer.
For example,
PaddingAndLengthCheckForCharVarchar could fail query when resolveOperatorsUpWithNewOutput
with
Why are the changes needed?
trivial bugfix
Does this PR introduce any user-facing change?
no
How was this patch tested?
new tests