Skip to content

[SPARK-3443][MLLIB] update default values of tree: #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

mengxr
Copy link
Contributor

@mengxr mengxr commented Sep 8, 2014

Adjust the default values of decision tree, based on the memory requirement discussed in #2125 :

  1. maxMemoryInMB: 128 -> 256
  2. maxBins: 100 -> 32
  3. maxDepth: 4 -> 5 (in some example code)

@jkbradley

1. maxMemoryInMB: 128 -> 256
2. maxBins: 100 -> 32
3. maxDepth: 4 -> 5 (in some example code)
@mengxr
Copy link
Contributor Author

mengxr commented Sep 8, 2014

Jenkins, test this please.

@jkbradley
Copy link
Member

@mengxr I could only find a few items missed (in comments): Look in DecisionTree for "(suggested value:"

@mengxr
Copy link
Contributor Author

mengxr commented Sep 8, 2014

test this please

@SparkQA
Copy link

SparkQA commented Sep 8, 2014

QA tests have started for PR 2322 at commit 5900445.

  • This patch merges cleanly.

@jkbradley
Copy link
Member

@mengxr LGTM

@SparkQA
Copy link

SparkQA commented Sep 8, 2014

QA tests have finished for PR 2322 at commit 5900445.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • logDebug("isMulticlass = " + metadata.isMulticlass)
    • logDebug("isMulticlass = " + metadata.isMulticlass)

@SparkQA
Copy link

SparkQA commented Sep 8, 2014

QA tests have started for PR 2322 at commit cda453a.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 8, 2014

QA tests have finished for PR 2322 at commit cda453a.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor Author

mengxr commented Sep 9, 2014

test this please

@SparkQA
Copy link

SparkQA commented Sep 9, 2014

QA tests have started for PR 2322 at commit cda453a.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 9, 2014

QA tests have finished for PR 2322 at commit cda453a.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor Author

mengxr commented Sep 9, 2014

I've merged this into master. Thanks @jkbradley for review!

@asfgit asfgit closed this in 50a4fa7 Sep 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants