Skip to content

[SPARK-14359] Unit tests for java 8 lambda syntax with typed aggregates #12181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Apr 5, 2016

What changes were proposed in this pull request?

Adds unit tests for java 8 lambda syntax with typed aggregates as a follow-up to #12168

How was this patch tested?

Unit tests.

@ericl
Copy link
Contributor Author

ericl commented Apr 5, 2016

@rxin

@JoshRosen
Copy link
Contributor

[warn] Java 8 tests will not run because JDK version is < 1.8.

I think that the default PR builder might still be running Java 7 because my first attempt at switching to Java 8 seemed to have introduced some transient flakiness. I'm going to go ahead and re-push the config changes to enable the Java 8 tests and will fix any flakiness that crops up. I'll email dev@ now to let folks know.

@JoshRosen
Copy link
Contributor

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Apr 5, 2016

Test build #55014 has finished for PR 12181 at commit cc745c5.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • public class Java8DatasetAggregatorSuite extends JavaDatasetAggregatorSuiteBase
    • public class JavaDatasetAggregatorSuite extends JavaDatasetAggregatorSuiteBase
    • class JavaDatasetAggregatorSuiteBase implements Serializable

/**
* Common test base shared across this and Java8DatasetAggregatorSuite.
*/
class JavaDatasetAggregatorSuiteBase implements Serializable {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you define two java classes in one file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine as long as there is only one public class.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird you got two here.

@SparkQA
Copy link

SparkQA commented Apr 5, 2016

Test build #55022 has finished for PR 12181 at commit cc745c5.

  • This patch passes all tests.
  • This patch does not merge cleanly.
  • This patch adds the following public classes (experimental):
    • public class Java8DatasetAggregatorSuite extends JavaDatasetAggregatorSuiteBase
    • public class JavaDatasetAggregatorSuite extends JavaDatasetAggregatorSuiteBase
    • class JavaDatasetAggregatorSuiteBase implements Serializable

@rxin
Copy link
Contributor

rxin commented Apr 6, 2016

LGTM - merging in master.

@asfgit asfgit closed this in 7d29c72 Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants