Add processor based calculation for the eventing threadpool#38
Add processor based calculation for the eventing threadpool#38royteeuwen wants to merge 4 commits intomasterfrom
Conversation
|
The build still seems to fail, on Java 11 linux, while the same issue does not occur for me on Java 11... Will have to investigate further |
joerghoh
left a comment
There was a problem hiding this comment.
in general looks good, thanks Roy!
I am worried a bit about the change in the configuration from int to a double, can you check that it still works when a INT is provided?
Doing a functional change next to the dependency updates make this change hard to assess. Can you split the PR into the functional change and another one for the updates to the pom?
src/main/java/org/apache/sling/event/impl/EventingThreadPool.java
Outdated
Show resolved
Hide resolved
|
@royteeuwen Do you have some time to pick up the comments from @joerghoh ? Would be great to merge this in. |
bc29fd1 to
e470c94
Compare
Resolved and answered his comments. I also removed the update of the parent of this PR and just made the PR build on JDK11 only. Still it seems that the windows 11 build fails, only the linux one succeeds so far. (don't think its related to my PR though). Any suggestions on going forward? |
|
We probably need to get the ITs stable first, I made an attempt in #37. |
|



No description provided.