Skip to content

Feature/update parent#37

Closed
kwin wants to merge 7 commits intomasterfrom
feature/update-parent
Closed

Feature/update parent#37
kwin wants to merge 7 commits intomasterfrom
feature/update-parent

Conversation

@kwin
Copy link
Member

@kwin kwin commented Mar 1, 2024

No description provided.

@kwin kwin requested a review from stefan-egli March 1, 2024 16:20
@kwin kwin force-pushed the feature/update-parent branch from e767b20 to b33a1b5 Compare October 23, 2024 09:31
@kwin
Copy link
Member Author

kwin commented Oct 25, 2024

@stefan-egli I would love to get the CI back to green for this module, can you look at the failing test in https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-event/job/PR-37/8/console? I am not really familiar with the ITs in here.

@kwin
Copy link
Member Author

kwin commented Oct 25, 2024

The broken build currently prevents applying additional PRs....

@stefan-egli
Copy link
Contributor

I will have a look when I find time. In the meantime if anyone else can jump in, feel free to do so.

@kwin
Copy link
Member Author

kwin commented Oct 28, 2024

The first step would be to increase the logging in terms of which events are received and which ones are expected instead of just asserting the count.

@kwin kwin force-pushed the feature/update-parent branch from a63a378 to 043bd6f Compare October 28, 2024 18:33
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
53.3% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@kwin
Copy link
Member Author

kwin commented Oct 10, 2025

Superseded by #47

@kwin kwin closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants