Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type: test] Add unit test for NacosDiscoveryService #5310

Merged
merged 8 commits into from
Nov 21, 2023
Merged

[type: test] Add unit test for NacosDiscoveryService #5310

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3947ba3
[type:test] add unit test for NacosDiscoveryService
eurecalulu Nov 20, 2023
e4da5b1
[type:test] Add the statement at the beginning
eurecalulu Nov 20, 2023
4691339
Merge branch 'master' into add-ut-discovery
yu199195 Nov 20, 2023
c890a8d
trigger ci
eurecalulu Nov 20, 2023
bed4b18
test ci
eurecalulu Nov 20, 2023
fa5c405
test ci
eurecalulu Nov 20, 2023
2dae720
test ci
eurecalulu Nov 20, 2023
51f2bcc
test ci
eurecalulu Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test ci
  • Loading branch information
@eurecalulu
eurecalulu committed Nov 20, 2023
commit 2dae7208a50bc339fc1df24c41676f304f1b27e2
3 changes: 2 additions & 1 deletion ...very-nacos/src/test/java/org/apache/shenyu/discovery/nacos/NacosDiscoveryServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,8 @@ void testRegister() throws NacosException {
nacosDiscoveryServiceUnderTest.register(key, value);
// Verify whether the method is called correctly
verify(namingService).registerInstance(anyString(), anyString(), any(Instance.class));
// Mock the wrong json format
assertThrows(ShenyuException.class, () -> nacosDiscoveryServiceUnderTest.register(key, "test"));
// Mock the throwing of registerInstance exception
doThrow(new NacosException()).when(namingService).registerInstance(anyString(), anyString(), any(Instance.class));
assertThrows(ShenyuException.class, () -> nacosDiscoveryServiceUnderTest.register(key, value));
Expand Down Expand Up @@ -237,4 +239,3 @@ private String buildInstanceInfoJson(final Instance instance) {
}

}