Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type: test] Add unit test for NacosDiscoveryService #5310

Merged
merged 8 commits into from
Nov 21, 2023

Conversation

eurecalulu
Copy link
Contributor

@eurecalulu eurecalulu commented Nov 20, 2023

related to #5278

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (928c802) 62.06% compared to head (2dae720) 61.96%.

Files Patch % Lines
...he/shenyu/admin/model/enums/DiscoveryTypeEnum.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5310      +/-   ##
============================================
- Coverage     62.06%   61.96%   -0.11%     
+ Complexity     8682     8670      -12     
============================================
  Files          1252     1253       +1     
  Lines         38064    38191     +127     
  Branches       3645     3656      +11     
============================================
+ Hits          23625    23664      +39     
- Misses        12348    12423      +75     
- Partials       2091     2104      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moremind moremind added this to the 2.6.1 milestone Nov 21, 2023
@moremind moremind merged commit 63e463a into apache:master Nov 21, 2023
@eurecalulu eurecalulu deleted the add-ut-discovery branch November 21, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants